-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21055/#review42098
-----------------------------------------------------------



3rdparty/python/BUILD
<https://reviews.apache.org/r/21055/#comment75840>

    can not depend on the .git dir at the tlp as in the release there is no 
.git dir



build-support/jenkins/build_mesos.sh
<https://reviews.apache.org/r/21055/#comment75844>

    Since this is only used by build_executor jenkins script does it need to be 
its own file?



build-support/jenkins/build_mesos.sh
<https://reviews.apache.org/r/21055/#comment75841>

    space at end of line



build-support/jenkins/build_mesos.sh
<https://reviews.apache.org/r/21055/#comment75842>

    this should detect python version like all other py scripts in use



src/test/python/apache/aurora/executor/test_thermos_executor.py
<https://reviews.apache.org/r/21055/#comment75843>

    Nice catch


- Jake Farrell


On May 4, 2014, 12:02 a.m., Dan Norris wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21055/
> -----------------------------------------------------------
> 
> (Updated May 4, 2014, 12:02 a.m.)
> 
> 
> Review request for Aurora, Jake Farrell, Kevin Sweeney, Bill Farner, and 
> Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-14: Add jenkins-compatible script to build mesos core egg and run 
> executor-large tests
> 
> I took this over from wickman at his request (old review: 
> https://reviews.apache.org/r/19955/).
> 
> Changes:
> - Use mesos 0.18.0 instead of 0.17.0
> - Download mesos source from apache.org
> - Conditionally build mesos .egg
> - Fix a test in test_thermos_executor.py that was broken
> 
> 
> Diffs
> -----
> 
>   .mesosversion PRE-CREATION 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
>   build-support/jenkins/build_executor.sh PRE-CREATION 
>   build-support/jenkins/build_mesos.sh PRE-CREATION 
>   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 0b143d0a2cbb25c1d35f79963478800a6b6713ec 
> 
> Diff: https://reviews.apache.org/r/21055/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build_mesos.sh && ./pants 
> src/test/python/apache/aurora/executor:executor-large -vxs (what the new 
> build_executor.sh script does)
> 
> 
> Thanks,
> 
> Dan Norris
> 
>

Reply via email to