-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20928/#review42322
-----------------------------------------------------------

Ship it!


Also, please reply to the review comments inline.


src/main/python/apache/aurora/client/cli/command_hooks.py
<https://reviews.apache.org/r/20928/#comment76085>

    To keep it DRY, just point to the design doc at the top of the file.



src/main/python/apache/aurora/client/cli/command_hooks.py
<https://reviews.apache.org/r/20928/#comment76086>

    To keep it DRY, just point to the design doc at the top of the file.


- Suman Karumuri


On May 6, 2014, 2:47 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20928/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 2:47 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Suman Karumuri.
> 
> 
> Bugs: aurora-270
>     https://issues.apache.org/jira/browse/aurora-270
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The second half of command hooks: 
> - Dynamically registered hook exceptions are provided, by fetching a hooks 
> skip rules file from a 
>   URL.
> - Hooks are loaded and activated by the noun/verb framework.
> - Hook selection and dispatch has been substantially updated.
> 
> Also did some long overdue cleanup of string quoting consistency.
> 
> 
> Diffs
> -----
> 
>   .auroraversion f0334e962b038d4b8a8de7ce87a8dd445616a0ea 
>   3rdparty/python/BUILD 122f71db0bc6f37c19ae0f3cb2fcade8321404e6 
>   docs/design/command-hooks.md ee320ed3922928408d23a2dfdf3c42ef96e62ff7 
>   src/main/python/apache/aurora/client/cli/BUILD 
> 1bd565effb3dbe2aeb5d6156575e9316bd77c6a8 
>   src/main/python/apache/aurora/client/cli/__init__.py 
> 1e396b2263451b41cd223708f4cc4cdb1eeddbf0 
>   src/main/python/apache/aurora/client/cli/command_hooks.py 
> 2d200682209e1df83c03f9d515f3b118aaa85a99 
>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 
> 6c6f6f58e0263aeb6442d48e32ea13f1e3b98479 
> 
> Diff: https://reviews.apache.org/r/20928/diff/
> 
> 
> Testing
> -------
> 
> [sun-wukong incubator-aurora (command-hooks-two)]$ !./p
> ./pants src/test/python/apache/aurora/client/cli:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)])
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_bridge.py ....
> 
> =========================== 4 passed in 0.02 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 9 items
> 
> src/test/python/apache/aurora/client/cli/test_command_hooks.py .........
> 
> =========================== 9 passed in 0.80 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_help.py .....
> 
> =========================== 5 passed in 0.70 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 36 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py .........
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ...
> src/test/python/apache/aurora/client/cli/test_status.py .......
> src/test/python/apache/aurora/client/cli/test_update.py ...
> 
> ========================== 36 passed in 2.02 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 1 items
> 
> src/test/python/apache/aurora/client/cli/test_logging.py .
> 
> =========================== 1 passed in 0.65 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 3 items
> 
> src/test/python/apache/aurora/client/cli/test_plugins.py ...
> 
> =========================== 3 passed in 0.67 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 4 items
> 
> src/test/python/apache/aurora/client/cli/test_quota.py ....
> 
> =========================== 4 passed in 0.67 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 5 items
> 
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> 
> =========================== 5 passed in 0.72 seconds 
> ===========================
> ============================= test session starts 
> ==============================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> plugins: cov
> collected 2 items
> 
> src/test/python/apache/aurora/client/cli/test_task_run.py ..
> 
> =========================== 2 passed in 0.65 seconds 
> ===========================
> src.test.python.apache.aurora.client.cli.bridge                               
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.command_hooks                        
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.help                                 
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.job                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.logging                              
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.plugins                              
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.quota                                
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.sla                                  
>   .....   SUCCESS
> src.test.python.apache.aurora.client.cli.task                                 
>   .....   SUCCESS
> [sun-wukong incubator-aurora (command-hooks-two)]$
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to