----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21232/#review42615 -----------------------------------------------------------
- Suman Karumuri On May 8, 2014, 6:54 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21232/ > ----------------------------------------------------------- > > (Updated May 8, 2014, 6:54 p.m.) > > > Review request for Aurora, David McLaughlin and Suman Karumuri. > > > Bugs: aurora-401 > https://issues.apache.org/jira/browse/aurora-401 > > > Repository: aurora > > > Description > ------- > > Add a strict mode for commands that specify instances. > > If strict mode is on, and users specify an invalid shard range (a range > that's larger that the actual > number of shards), then generate an error. > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/context.py > 609285ade4c065a9c70153f9b29e1ffe5dc68147 > src/main/python/apache/aurora/client/cli/jobs.py > cf45640a66c76ae4daa0ceaa3ff8da80c4cbe91d > src/main/python/apache/aurora/client/cli/options.py > 040c5c213798e644ba59c4ce3f9c4fe8868af2d5 > src/test/python/apache/aurora/client/cli/test_kill.py > e11fc81061c9bd9f8cb6aa1108e2e94e96f616d5 > src/test/python/apache/aurora/client/cli/test_restart.py > 9b7a2c69b53d4be35587f630f429943a4907b74b > > Diff: https://reviews.apache.org/r/21232/diff/ > > > Testing > ------- > > [sun-wukong incubator-aurora (shard_errors)]$ ./pants > src/test/python/apache/aurora/client/cli:all > Build operating on targets: > OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) > ============================================ test session starts > ============================================= > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 4 items > > src/test/python/apache/aurora/client/cli/test_bridge.py .... > > ========================================== 4 passed in 0.02 seconds > ========================================== > ============================================ test session starts > ============================================= > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 9 items > > src/test/python/apache/aurora/client/cli/test_command_hooks.py ......... > > ========================================== 9 passed in 0.79 seconds > ========================================== > ============================================ test session starts > ============================================= > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 5 items > > src/test/python/apache/aurora/client/cli/test_help.py ..... > > ========================================== 5 passed in 0.64 seconds > ========================================== > ============================================ test session starts > ============================================= > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 40 items > > src/test/python/apache/aurora/client/cli/test_cancel_update.py .. > src/test/python/apache/aurora/client/cli/test_create.py .... > src/test/python/apache/aurora/client/cli/test_diff.py ... > src/test/python/apache/aurora/client/cli/test_kill.py ............ > src/test/python/apache/aurora/client/cli/test_open.py ..... > src/test/python/apache/aurora/client/cli/test_restart.py .... > src/test/python/apache/aurora/client/cli/test_status.py ....... > src/test/python/apache/aurora/client/cli/test_update.py ... > > ========================================= 40 passed in 2.14 seconds > ========================================== > ============================================ test session starts > ============================================= > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 1 items > > src/test/python/apache/aurora/client/cli/test_logging.py . > > ========================================== 1 passed in 0.68 seconds > ========================================== > ============================================ test session starts > ============================================= > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 3 items > > src/test/python/apache/aurora/client/cli/test_plugins.py ... > > ========================================== 3 passed in 0.90 seconds > ========================================== > ============================================ test session starts > ============================================= > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 4 items > > src/test/python/apache/aurora/client/cli/test_quota.py .... > > ========================================== 4 passed in 0.66 seconds > ========================================== > ============================================ test session starts > ============================================= > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 5 items > > src/test/python/apache/aurora/client/cli/test_sla.py ..... > > ========================================== 5 passed in 0.65 seconds > ========================================== > ============================================ test session starts > ============================================= > platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 > plugins: cov > collected 2 items > > src/test/python/apache/aurora/client/cli/test_task_run.py .. > > ========================================== 2 passed in 0.63 seconds > ========================================== > src.test.python.apache.aurora.client.cli.bridge > ..... SUCCESS > src.test.python.apache.aurora.client.cli.command_hooks > ..... SUCCESS > src.test.python.apache.aurora.client.cli.help > ..... SUCCESS > src.test.python.apache.aurora.client.cli.job > ..... SUCCESS > src.test.python.apache.aurora.client.cli.logging > ..... SUCCESS > src.test.python.apache.aurora.client.cli.plugins > ..... SUCCESS > src.test.python.apache.aurora.client.cli.quota > ..... SUCCESS > src.test.python.apache.aurora.client.cli.sla > ..... SUCCESS > src.test.python.apache.aurora.client.cli.task > ..... SUCCESS > [sun-wukong incubator-aurora (shard_errors)]$ > > > Thanks, > > Mark Chu-Carroll > >
