This is an automatically generated e-mail. To reply, visit:

(Updated May 12, 2014, 5:25 p.m.)

Review request for Aurora and Kevin Sweeney.


Moved src/.isort.cfg to root .isort.cfg -- this seems more consistent with the 
rest of our dotfiles.

Bugs: AURORA-149

Repository: aurora


Adds build-support/isort wrapper for isort.
Adds build-support/isort-run to run import sort, build-support/isort-check to 
run import order check.
Adds build-support/hooks which contains hooks that people can place into their 
.git/hooks directory, currently just a pre-commit hook that checks import sort 
order (which can be overridden with an environment variable.)

The ordering it produces is different than the one we currently have but closer 
to straight PEP8.  If it runs, it's about a 500 line diff which I can send 

Diffs (updated)

  .isort.cfg PRE-CREATION 
  build-support/hooks/pre-commit PRE-CREATION 
  build-support/isort PRE-CREATION 
  build-support/isort-check PRE-CREATION 
  build-support/isort-run PRE-CREATION 

Diff: https://reviews.apache.org/r/21136/diff/


Ran the isort and ran tests, everything worked.


Brian Wickman

Reply via email to