-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21223/
-----------------------------------------------------------
(Updated May 12, 2014, 1:08 p.m.)
Review request for Aurora, David McLaughlin and Maxim Khutornenko.
Changes
-------
Fix whitespace, rebase to master.
Bugs: aurora-400
https://issues.apache.org/jira/browse/aurora-400
Repository: aurora
Description
-------
Bugfix: make "restart" command generate a correct error message in some cases.
Diffs (updated)
-----
src/main/python/apache/aurora/client/api/restarter.py
ddaec5c6faeec75458a16e93e08f2eeaad9ce5a0
src/test/python/apache/aurora/client/api/test_restarter.py
d5dfa3925ee18ab8f2e66a56f90da5d62a7b04da
src/test/python/apache/aurora/client/cli/test_restart.py
03fdcd2b0c6ace026d01a68f32d7c99ef252fab9
src/test/python/apache/aurora/client/commands/test_restart.py
9af6334264f40cbccbef545bd15ffa85171ad348
Diff: https://reviews.apache.org/r/21223/diff/
Testing
-------
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 2 items
src/test/python/apache/aurora/client/test_binding_helper.py ..
=========================== 2 passed in 0.35 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items
src/test/python/apache/aurora/client/test_config.py ......
=========================== 6 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items
src/test/python/apache/aurora/client/api/test_disambiguator.py ......
=========================== 6 passed in 0.42 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items
src/test/python/apache/aurora/client/api/test_job_monitor.py ....
=========================== 4 passed in 0.42 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items
src/test/python/apache/aurora/client/api/test_restarter.py ......
=========================== 6 passed in 0.34 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 47 items / 1 skipped
src/test/python/apache/aurora/client/api/test_scheduler_client.py
...............................................
===================== 47 passed, 1 skipped in 3.68 seconds =====================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 12 items
src/test/python/apache/aurora/client/api/test_instance_watcher.py ........
src/test/python/apache/aurora/client/api/test_health_check.py ....
========================== 12 passed in 0.22 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 28 items
src/test/python/apache/aurora/client/api/test_updater.py
............................
========================== 28 passed in 0.65 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 6 items
src/test/python/apache/aurora/client/api/test_quota_check.py ......
=========================== 6 passed in 0.15 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 33 items
src/test/python/apache/aurora/client/api/test_sla.py
.................................
========================== 33 passed in 0.26 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items
src/test/python/apache/aurora/client/cli/test_bridge.py ....
=========================== 4 passed in 0.02 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 9 items
src/test/python/apache/aurora/client/cli/test_command_hooks.py .........
=========================== 9 passed in 0.70 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items
src/test/python/apache/aurora/client/cli/test_help.py .....
=========================== 5 passed in 0.61 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 38 items
src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py ..........
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_restart.py ....
src/test/python/apache/aurora/client/cli/test_status.py .......
src/test/python/apache/aurora/client/cli/test_update.py ...
========================== 38 passed in 1.96 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items
src/test/python/apache/aurora/client/cli/test_logging.py .
=========================== 1 passed in 0.70 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items
src/test/python/apache/aurora/client/cli/test_plugins.py ...
=========================== 3 passed in 0.65 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items
src/test/python/apache/aurora/client/cli/test_quota.py ....
=========================== 4 passed in 0.65 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 5 items
src/test/python/apache/aurora/client/cli/test_sla.py .....
=========================== 5 passed in 0.66 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 2 items
src/test/python/apache/aurora/client/cli/test_task_run.py ..
=========================== 2 passed in 0.63 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 13 items
src/test/python/apache/aurora/client/commands/test_admin_sla.py .............
========================== 13 passed in 0.48 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 30 items
src/test/python/apache/aurora/client/commands/test_cancel_update.py ..
src/test/python/apache/aurora/client/commands/test_create.py ......
src/test/python/apache/aurora/client/commands/test_diff.py ...
src/test/python/apache/aurora/client/commands/test_kill.py ........
src/test/python/apache/aurora/client/commands/test_listjobs.py ..
src/test/python/apache/aurora/client/commands/test_restart.py ...
src/test/python/apache/aurora/client/commands/test_status.py ...
src/test/python/apache/aurora/client/commands/test_update.py ...
========================== 30 passed in 1.36 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 3 items
src/test/python/apache/aurora/client/commands/test_hooks.py ...
=========================== 3 passed in 1.03 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items
src/test/python/apache/aurora/client/commands/test_maintenance.py ....
=========================== 4 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items
src/test/python/apache/aurora/client/commands/test_run.py .
=========================== 1 passed in 0.46 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 1 items
src/test/python/apache/aurora/client/commands/test_ssh.py .
=========================== 1 passed in 0.45 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 12 items
src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
========================== 12 passed in 0.44 seconds ===========================
============================= test session starts ==============================
platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
plugins: cov
collected 4 items
src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ....
=========================== 4 passed in 0.41 seconds ===========================
Build operating on targets:
OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/BUILD:all)])
src.test.python.apache.aurora.client.api.disambiguator
..... SUCCESS
src.test.python.apache.aurora.client.api.instance_watcher
..... SUCCESS
src.test.python.apache.aurora.client.api.job_monitor
..... SUCCESS
src.test.python.apache.aurora.client.api.quota_check
..... SUCCESS
src.test.python.apache.aurora.client.api.restarter
..... SUCCESS
src.test.python.apache.aurora.client.api.scheduler_client
..... SUCCESS
src.test.python.apache.aurora.client.api.sla
..... SUCCESS
src.test.python.apache.aurora.client.api.updater
..... SUCCESS
src.test.python.apache.aurora.client.binding_helper
..... SUCCESS
src.test.python.apache.aurora.client.cli.bridge
..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks
..... SUCCESS
src.test.python.apache.aurora.client.cli.help
..... SUCCESS
src.test.python.apache.aurora.client.cli.job
..... SUCCESS
src.test.python.apache.aurora.client.cli.logging
..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins
..... SUCCESS
src.test.python.apache.aurora.client.cli.quota
..... SUCCESS
src.test.python.apache.aurora.client.cli.sla
..... SUCCESS
src.test.python.apache.aurora.client.cli.task
..... SUCCESS
src.test.python.apache.aurora.client.commands.admin
..... SUCCESS
src.test.python.apache.aurora.client.commands.core
..... SUCCESS
src.test.python.apache.aurora.client.commands.hooks
..... SUCCESS
src.test.python.apache.aurora.client.commands.maintenance
..... SUCCESS
src.test.python.apache.aurora.client.commands.run
..... SUCCESS
src.test.python.apache.aurora.client.commands.ssh
..... SUCCESS
src.test.python.apache.aurora.client.config
..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
..... SUCCESS
Thanks,
Mark Chu-Carroll
