> On May 12, 2014, 10:17 p.m., Kevin Sweeney wrote: > > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java, line 241 > > <https://reviews.apache.org/r/21294/diff/1/?file=578006#file578006line241> > > > > Runnable?
I explored that, but Runnable has the downside of declaring no checked exceptions, so i would have to add more code to try/catch/rethrow MonitorException. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21294/#review42757 ----------------------------------------------------------- On May 10, 2014, 12:50 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21294/ > ----------------------------------------------------------- > > (Updated May 10, 2014, 12:50 a.m.) > > > Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Maxim > Khutornenko. > > > Bugs: AURORA-342 > https://issues.apache.org/jira/browse/AURORA-342 > > > Repository: aurora > > > Description > ------- > > Only serve thrift over HTTP. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java > c14d5c2d059e8970b2f232b7a2a0958ba8cffcb8 > src/main/java/org/apache/aurora/scheduler/thrift/ThriftServer.java > 5b55e941d8efb17fd8740614d8f67cea3931e2c5 > src/main/java/org/apache/aurora/scheduler/thrift/ThriftServerLauncher.java > bb93be365cfe4f85433e6055290f39723735bd70 > src/main/python/apache/aurora/client/api/scheduler_client.py > b298d8f310b9e977d74c35a064554bc6d5ee563c > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > ddbb02560bb8fb94dafe26c1a66c767e9a3a863b > src/test/python/apache/aurora/client/api/test_scheduler_client.py > 2736d67e8c47c3ec8d32336aee9fd8cdf3eabc6d > src/test/python/apache/aurora/client/cli/BUILD > c0492cc41c5e253fb3a38e347081fe9ef68f3426 > src/test/resources/org/apache/aurora/scheduler/app/AuroraTestKeyStore > 1157471621099e296fef156dd49569cd9f47e3c1 > > Diff: https://reviews.apache.org/r/21294/diff/ > > > Testing > ------- > > I also fixed a bad BUILD reference that was causing python tests to fail. > > vagrant up > bash examples/vagrant/test_tutorial.sh > > > bash build-support/jenkins/build.sh > > > Thanks, > > Bill Farner > >
