> On May 13, 2014, 9:19 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/config.py, line 130 > > <https://reviews.apache.org/r/21297/diff/1/?file=578010#file578010line130> > > > > curious if we should be adding a delta here? if we just do watch_secs > > >= initial_interval_secs, then we'll race with that first health check > > delivery from the executor -> scheduler -> client. > > > > 5s? not sure. what do you think?
I was split on that too. Feels like the primary goal here should be raising awareness rather than giving any guarantees. That said, 5s might be a nice to have safety default to provide. Done. > On May 13, 2014, 9:19 p.m., Brian Wickman wrote: > > src/test/python/apache/aurora/client/test_config.py, line 178 > > <https://reviews.apache.org/r/21297/diff/1/?file=578015#file578015line178> > > > > 2 newlines between top level tests Done. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21297/#review42887 ----------------------------------------------------------- On May 10, 2014, 1:15 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21297/ > ----------------------------------------------------------- > > (Updated May 10, 2014, 1:15 a.m.) > > > Review request for Aurora and Brian Wickman. > > > Bugs: AURORA-404 > https://issues.apache.org/jira/browse/AURORA-404 > > > Repository: aurora > > > Description > ------- > > Adding checks for watch_secs, initial_interval_secs and restart_threshold. > > > Diffs > ----- > > src/main/python/apache/aurora/client/config.py > 350d84c97fac9f1dd834bf509a160faaacb26386 > src/main/python/apache/aurora/config/__init__.py > 74e6b21ef905221cb3beb974a540325937480f2e > src/main/python/apache/aurora/config/schema/base.py > 61a6680f8b1a463055ccd6d318cc540aca166684 > src/test/python/apache/aurora/client/cli/util.py > e17f256fc5d17f251e8f2cb4d94233d2d6c09897 > src/test/python/apache/aurora/client/commands/util.py > c28096fe89c9af6d5518bc0f8f871e886ca12e7f > src/test/python/apache/aurora/client/test_config.py > 8ef08685c317c3f9dae799dfb6bdced7077a8778 > > Diff: https://reviews.apache.org/r/21297/diff/ > > > Testing > ------- > > ./pants src/test/python:all > > > Thanks, > > Maxim Khutornenko > >
