> On May 14, 2014, 8:32 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/config.py, lines 131-133 > > <https://reviews.apache.org/r/21297/diff/2-3/?file=580996#file580996line131> > > > > Rather than spell out a formula which may be a little intimidating, > > could you say something more consumable like: > > > > "You have specified an insufficiently long watch period (%d seconds) in > > your update configuration. Your update will always succeed. > > > > In order for health notifications to be delivered, > > UpdateConfig.watch_secs must be set to at least %d seconds. This > > corresponds to an initial health check interval (%d seconds) plus %d > > consecutive failures at a check interval of %d seconds." > > > > With blanks filled in appropriately. > > > > Agree y/n?
Thanks for shaping it up so nicely. Unit test output: ..CRITICAL:root: You have specified an insufficiently short watch period (10 seconds) in your update configuration. Your update will always succeed. In order for health notifications to be delivered, UpdateConfig.watch_secs must be set to at least 15 seconds. This corresponds to an initial health check interval (15 seconds) plus 0 consecutive failures at a check interval of 10 seconds. .CRITICAL:root: You have specified an insufficiently short watch period (20 seconds) in your update configuration. Your update will always succeed. In order for health notifications to be delivered, UpdateConfig.watch_secs must be set to at least 25 seconds. This corresponds to an initial health check interval (15 seconds) plus 1 consecutive failures at a check interval of 10 seconds. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21297/#review43014 ----------------------------------------------------------- On May 14, 2014, 8:01 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21297/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 8:01 p.m.) > > > Review request for Aurora, Kevin Sweeney and Brian Wickman. > > > Bugs: AURORA-404 > https://issues.apache.org/jira/browse/AURORA-404 > > > Repository: aurora > > > Description > ------- > > Adding checks for watch_secs, initial_interval_secs and restart_threshold. > > > Diffs > ----- > > src/main/python/apache/aurora/client/config.py > 350d84c97fac9f1dd834bf509a160faaacb26386 > src/main/python/apache/aurora/config/__init__.py > 74e6b21ef905221cb3beb974a540325937480f2e > src/main/python/apache/aurora/config/schema/base.py > 61a6680f8b1a463055ccd6d318cc540aca166684 > src/test/python/apache/aurora/client/cli/util.py > e17f256fc5d17f251e8f2cb4d94233d2d6c09897 > src/test/python/apache/aurora/client/commands/util.py > c28096fe89c9af6d5518bc0f8f871e886ca12e7f > src/test/python/apache/aurora/client/test_config.py > 8ef08685c317c3f9dae799dfb6bdced7077a8778 > > Diff: https://reviews.apache.org/r/21297/diff/ > > > Testing > ------- > > ./pants src/test/python:all > > > Thanks, > > Maxim Khutornenko > >
