-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19767/
-----------------------------------------------------------

(Updated May 14, 2014, 5:08 p.m.)


Review request for Aurora, Maxim Khutornenko and Bill Farner.


Changes
-------

Merge https://reviews.apache.org/r/20640/, undo revert on master


Bugs: AURORA-132 and AURORA-349
    https://issues.apache.org/jira/browse/AURORA-132
    https://issues.apache.org/jira/browse/AURORA-349


Repository: aurora


Description
-------

This introduces a new CronScheduler based on Quartz and removes the 
NoopCronScheduler.


Diffs (updated)
-----

  build.gradle f2c729e28b01c89e2130c48d2aa43d7c830528a5 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
86bbc29c64dd62037ad6bc51b8daa30115eaf74c 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 
  src/main/java/org/apache/aurora/scheduler/async/TaskGroups.java 
38e19aac7c911f52fcb05cda90f5095f688c5cb2 
  src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
db1bec4f508c8908f212aa541fb86e041a8c471c 
  
src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
 82034e008e5dbaa3124dc154cdc6c5e9767ca87f 
  src/main/java/org/apache/aurora/scheduler/cron/CronJobManager.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/CronPredictor.java 
df0c37839c5da54795404c18ff9fc93084cd32e4 
  src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java 
56e9950fd94ae1e3dbd96baec00b7e6b262fbe34 
  src/main/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java 
2bb848a7f5f096b1c85596e4130f0656e9a4401e 
  src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronModule.java 
e0935f5eab8a101f4ce1831f260f9a23137124ce 
  src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronPredictor.java 
7b25152c0258e10be21b801cae1444c518367fa7 
  src/main/java/org/apache/aurora/scheduler/cron/noop/NoopCronScheduler.java 
a31551c77818c17ee0f9f71b5ab458a3b853dc6a 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java 
PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImpl.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java 
61b01d2575d6cfce069e77c39bfa8f8680cf4298 
  src/main/java/org/apache/aurora/scheduler/http/Cron.java 
80a398a5f297558a25c0a0c63afcb049a9558e44 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
983101277ffbd1c4017b29f4c86e61315f1bcc78 
  src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
efea75f3d5a5f4c538c63cc15d5a004d891c2a4a 
  src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java 
ff7e3cb345032aa355fcc0dc8f96a2d716a24237 
  src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 
4bd190cd608c167f31f06fba6185ce825926e37e 
  src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 
5696485e5beb9b7bf4ccee8b6189f25db51aff39 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
f33059904fb5f6fc18a3a66dfe63c059008affe3 
  src/main/java/org/apache/aurora/scheduler/state/StateModule.java 
7d26082b74f62f35865e0343f9ba8b475e075d62 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
9bb5c255e1118038b953fc72f0a074d461ba1fb5 
  src/main/python/apache/aurora/config/thrift.py 
1798c403fa0198034a1cccc946830b7a355213d4 
  
src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json
  
  src/test/java/org/apache/aurora/scheduler/cron/ExpectedPrediction.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/cron/noop/NoopCronIT.java 
0d2f66fbabcdf16f92b051585593a4bb1770382a 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java
 PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronPredictorImplTest.java
 PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 
PRE-CREATION 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
da6c0ff1bdfaefef2f72ad2559f4059cd44612b6 
  src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 
fa9cb757936542c483699b3fc6bba944d717abac 
  src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 
c8ad55d8d48f7e96180846ab515dd4df3d8ed79e 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 405da0aa0d71d7378369904d74662f4de0839ab2 
  src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
488a5455bb498282b123d349a9df566c2cb204d7 

Diff: https://reviews.apache.org/r/19767/diff/


Testing
-------

./gradlew build


File Attachments
----------------

Coverage report.
  
https://reviews.apache.org/media/uploaded/files/2014/04/03/6b5f24f5-86a5-43d2-8a0e-d69fd24f7d2a__Screenshot_from_2014-04-02_203443.png


Thanks,

Kevin Sweeney

Reply via email to