> On May 18, 2014, 7:08 p.m., Brian Wickman wrote: > > src/main/python/apache/aurora/client/api/sla.py, lines 292-293 > > <https://reviews.apache.org/r/21597/diff/1/?file=583926#file583926line292> > > > > seems like we should have a log_response method instead of > > reimplementing here?
Sure, works for me. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21597/#review43327 ----------------------------------------------------------- On May 17, 2014, 12:18 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21597/ > ----------------------------------------------------------- > > (Updated May 17, 2014, 12:18 a.m.) > > > Review request for Aurora, Mark Chu-Carroll and Brian Wickman. > > > Bugs: AURORA-442 > https://issues.apache.org/jira/browse/AURORA-442 > > > Repository: aurora > > > Description > ------- > > Mistyped or unknown to scheduler hosts should not result in failing the SLA > command. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/sla.py > a20b5d46221981740e0b7d5f0958516560928b54 > src/test/python/apache/aurora/client/api/test_sla.py > 86b6775e51cab1214a6cae01145f19f08cc74499 > > Diff: https://reviews.apache.org/r/21597/diff/ > > > Testing > ------- > > ./pants src/test/python:all > > > Thanks, > > Maxim Khutornenko > >
