----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21735/#review43550 -----------------------------------------------------------
Ship it! Ship It! - Kevin Sweeney On May 20, 2014, 3:36 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21735/ > ----------------------------------------------------------- > > (Updated May 20, 2014, 3:36 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-453 > https://issues.apache.org/jira/browse/AURORA-453 > > > Repository: aurora > > > Description > ------- > > Fix bad class reference to THttpClient. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/scheduler_client.py > 75053b7f4df8b50233e92884f8d0ddc651b8b7f8 > > Diff: https://reviews.apache.org/r/21735/diff/ > > > Testing > ------- > > When i introduced the regression, i must have not run the tests i cited on > the review, or i must have been in a different branch - they definitely don't > pass without this fix. > > To hopefully convince myself and others that i am indeed running the test on > the correct code, including the git sha for more evidence: > > $ git log -1 --oneline; vagrant up >/dev/null; > ./examples/vagrant/test_tutorial.sh > 4576315 Fix bad class reference to THttpClient. > Checking scheduler health...\c > PASS > Checking observer health...\c > PASS > Checking master health...\c > PASS > Checking slave health...\c > PASS > Running create command...\c > PASS > Waiting to observe FAILED task...\c > PASS > Running update command...\c > PASS > Waiting to observe RUNNING task...\c > PASS > Running killall command...\c > PASS > > > Thanks, > > Bill Farner > >
