> On April 21, 2014, 2:58 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 61
> > <https://reviews.apache.org/r/20285/diff/1/?file=555585#file555585line61>
> >
> >     s/divide/break into groups/

done


> On April 21, 2014, 2:58 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 62
> > <https://reviews.apache.org/r/20285/diff/1/?file=555585#file555585line62>
> >
> >     s/strings/host names, which must match the host names that slaves are 
> > registered with/

done


> On April 21, 2014, 2:58 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 63
> > <https://reviews.apache.org/r/20285/diff/1/?file=555585#file555585line63>
> >
> >     Doc makes it sound like this is a callable being passed.  Either make 
> > it a callable, or note that it's a key into GROUPING_FUNCTIONS.

(I think) done, lemme know what you think


> On April 21, 2014, 2:58 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 89
> > <https://reviews.apache.org/r/20285/diff/1/?file=555585#file555585line89>
> >
> >     "Drains tasks from the specified hosts.
> >     
> >     This will move active tasks on these hosts to the DRAINING state, 
> > causing them to be rescheduled elsewhere."

definitely much much improved, thanks!


> On April 21, 2014, 2:58 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 93
> > <https://reviews.apache.org/r/20285/diff/1/?file=555585#file555585line93>
> >
> >     "Source for the current time"
> 
> Bill Farner wrote:
>     Doh, i asked RB to delete this one.

kk coo


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20285/#review40964
-----------------------------------------------------------


On April 12, 2014, 4:45 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20285/
> -----------------------------------------------------------
> 
> (Updated April 12, 2014, 4:45 p.m.)
> 
> 
> Review request for Aurora, David Robinson, Kevin Sweeney, Tobias Weingartner, 
> and Bill Farner.
> 
> 
> Bugs: AURORA-318
>     https://issues.apache.org/jira/browse/AURORA-318
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add way more docstrings as  well as unit tests for the HostMaintenance api.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 6a21ddeb4203a07a04360f68c4a338fe3da52c70 
>   src/test/python/apache/aurora/admin/BUILD 
> 17aac54d636024a8e131eb2e4d996c2e15401de1 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 95497aea3d3f769b2460adbfe7a7b72d775ced6f 
> 
> Diff: https://reviews.apache.org/r/20285/diff/
> 
> 
> Testing
> -------
> 
> 16:39:58 incubator-aurora $ ./pants ./src/test/python/apache/aurora/admin:all
> Build operating on targets: 
> OrderedSet([PythonTestSuite(src/test/python/apache/aurora/admin/BUILD:all)])
> ============================================================================================================
>  test session starts 
> =============================================================================================================
> platform darwin -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2
> collected 9 items 
> 
> src/test/python/apache/aurora/admin/test_host_maintenance.py .........
> 
> ==========================================================================================================
>  9 passed in 0.67 seconds 
> ==========================================================================================================
> src.test.python.apache.aurora.admin.host_maintenance                          
>   .....   SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>

Reply via email to