> On May 21, 2014, 10:42 p.m., Bill Farner wrote:
> > I agree with the wording on the ticket more than what's done here.  Having 
> > the range displayed when there's one group is still useful to see the 
> > instance count quickly.  It also verifies that there are not instances 
> > 'missing' (e.g. 4-99 would catch my eye).
> 
> David McLaughlin wrote:
>     My bad, I should have attached a screenshot. 
>     
>     This will just prevent groups with only one instance being shown as a 
> range.
>     
>     e.g.
>     
>     -------------------------
>     0 - 0   |  4 - 15 
>     -------------------------
>     
>     Becomes:
>     
>     -------------------------
>     0       |  4 - 15
>     -------------------------
>

Thanks for clarifying, this looks perfect.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21791/#review43664
-----------------------------------------------------------


On May 21, 2014, 10:35 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21791/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 10:35 p.m.)
> 
> 
> Review request for Aurora, Suman Karumuri and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-455
>     https://issues.apache.org/jira/browse/AURORA-455
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Do not show instance range when there is only one in group
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 
> 1fa1cea08d15109c96a2cd72c97fc1cc7b8fd0a7 
> 
> Diff: https://reviews.apache.org/r/21791/diff/
> 
> 
> Testing
> -------
> 
> Tested locally.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Reply via email to