> On May 22, 2014, 7:33 p.m., David McLaughlin wrote: > > I would have to object to the amount of new files added with this review. > > Is there any way to tell bower to only install the files defined in main? > > The vast majority of these new files are superfluous. > > Suman Karumuri wrote: > AFAICT, there is no way to install just the main files using bower. We > need a separate tool like https://github.com/blittle/bower-installer for that. > > The typical workflow for installing client side packages seems to be via > grunt, which downloads packages via bower, selects the files it needs, minify > them and produce them as a single js/css file respectively. > > I am not a fan of this approach, but this is has been the simplest > solution that keeps the right versions of dependencies (for example, what > version of jquery do I need for bootstrap3?) while making our build and > packaging story easier. Bower does allow us to download the files at build > time, but we didn't prefer that route because we will be taking a build time > dependency on node.js. > > However, as part of https://issues.apache.org/jira/browse/AURORA-451, I > will be looking at installing grunt. Once that is done, we can download npm > at build time just like we do with gradle. Once that is done, we can get rid > of all the bower_components entirely and install files at run time. > > I think for this review, we should just do what we are already doing and > explore the packaging story for client libraries in a separate ticket. > > David McLaughlin wrote: > What we are doing right now is just running bower manually, so why not > just use bower-installer?
We can use bower-installer as well. Opened https://issues.apache.org/jira/browse/AURORA-468 to discuss the future direction of this task. - Suman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21790/#review43760 ----------------------------------------------------------- On May 22, 2014, 7:09 p.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21790/ > ----------------------------------------------------------- > > (Updated May 22, 2014, 7:09 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-449 > https://issues.apache.org/jira/browse/AURORA-449 > > > Repository: aurora > > > Description > ------- > > Updated to bootstrap3 and jquery to 2.1.1. Upgraded smart-table to version > 0.2.1 since it is more friendly to bootstrap3. > Updated our html per bootstrap migration guide. > Fixed layout issues with new CSS. > Removed the extra large glyphicons set from our code base since we are using > svg icons from bootstrap3. > Added a .bowerrc file to make bower usable from project root. > Updated stats image to use glyphicons from bootstrap3. > Removed dividers from breadcrumb bar since we get them for free in bootstrap3. > > All the updated files are in page 1 and page 12. > > > Diffs > ----- > > .bowerrc PRE-CREATION > 3rdparty/javascript/bootstrap-glyphicons-master/README.md > b5182d74856bd362409508837606f8ccbddd9dad > > 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.css > 4a6b1ef28e2081414eff47d5056a82d6f268b9a1 > > 3rdparty/javascript/bootstrap-glyphicons-master/css/bootstrap.icon-large.min.css > 6d54222cd9f3ae9396a0fd0de9fe4d071a09af3c > 3rdparty/javascript/bootstrap-glyphicons-master/glyphicons.png > 0b858192e32cc3690ba3e9d71743c5ba64ec40fc > 3rdparty/javascript/bower_components/bootstrap.css/.bower.json > b20efca9a93e1f22472dde7c96f45269e7b9ef3e > 3rdparty/javascript/bower_components/bootstrap.css/README.md > b82b70e5b9b9092935e7105257a9bb22d5950ae6 > 3rdparty/javascript/bower_components/bootstrap.css/bower.json > 977c5817368e93febe7b75d3f70fbcf6cd73a385 > > 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.css > 09e88ce3fecc2812ad729e156975e2e53f8aea22 > > 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap-responsive.min.css > f4ede63f32e2ec803876a38efac05dd49acc4684 > 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.css > b725064aab21e434d29209d259d3892478aa9536 > 3rdparty/javascript/bower_components/bootstrap.css/css/bootstrap.min.css > b6428e695860151f82076e87810fe2d133339c2a > > 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings-white.png > 3bf6484a29d8da269f9bc874b25493a45fae3bae > > 3rdparty/javascript/bower_components/bootstrap.css/img/glyphicons-halflings.png > a9969993201f9cee63cf9f49217646347297b643 > 3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.js > 643e71cdf087886ad2909b69d9b8cee864d9ef2c > 3rdparty/javascript/bower_components/bootstrap.css/js/bootstrap.min.js > f9cbdae7c50d68635a3c8de0d35c29290fb1624b > 3rdparty/javascript/bower_components/bootstrap/.bower.json PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/Gruntfile.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/LICENSE PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/README.md PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/bower.json PRE-CREATION > > 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.eot > PRE-CREATION > > 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.svg > PRE-CREATION > > 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.ttf > PRE-CREATION > > 3rdparty/javascript/bower_components/bootstrap/fonts/glyphicons-halflings-regular.woff > PRE-CREATION > > 3rdparty/javascript/bower_components/bootstrap/grunt/bs-glyphicons-data-generator.js > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/grunt/bs-lessdoc-parser.js > PRE-CREATION > > 3rdparty/javascript/bower_components/bootstrap/grunt/bs-raw-files-generator.js > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/grunt/shrinkwrap.js > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/affix.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/alert.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/button.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/carousel.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/collapse.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/dropdown.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/modal.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/popover.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/scrollspy.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/tab.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/tooltip.js PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/js/transition.js > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/alerts.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/badges.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/bootstrap.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/breadcrumbs.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/button-groups.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/buttons.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/carousel.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/close.less PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/code.less PRE-CREATION > > 3rdparty/javascript/bower_components/bootstrap/less/component-animations.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/dropdowns.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/forms.less PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/glyphicons.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/grid.less PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/input-groups.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/jumbotron.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/labels.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/list-group.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/media.less PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/mixins.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/modals.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/navbar.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/navs.less PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/normalize.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/pager.less PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/pagination.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/panels.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/popovers.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/print.less PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/progress-bars.less > PRE-CREATION > > 3rdparty/javascript/bower_components/bootstrap/less/responsive-utilities.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/scaffolding.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/tables.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/theme.less PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/thumbnails.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/tooltip.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/type.less PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/utilities.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/variables.less > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/less/wells.less PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/package.json PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/test-infra/README.md > PRE-CREATION > > 3rdparty/javascript/bower_components/bootstrap/test-infra/npm-shrinkwrap.canonical.json > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/test-infra/requirements.txt > PRE-CREATION > 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py > PRE-CREATION > > 3rdparty/javascript/bower_components/bootstrap/test-infra/sauce_browsers.yml > PRE-CREATION > > 3rdparty/javascript/bower_components/bootstrap/test-infra/uncached-npm-install.sh > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/.bower.json > 83fe8cd16cfcf10e3c1bd1339fb0d94da1276750 > 3rdparty/javascript/bower_components/jquery/MIT-LICENSE.txt PRE-CREATION > 3rdparty/javascript/bower_components/jquery/bower.json PRE-CREATION > 3rdparty/javascript/bower_components/jquery/component.json > 99b1206450bd92e4a8b2db0acd3d8b445e38ba4f > 3rdparty/javascript/bower_components/jquery/jquery.js > 7893ca9e11b91a330a87abea9bbdcd917e2a4ac8 > 3rdparty/javascript/bower_components/jquery/src/ajax.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/ajax/jsonp.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/ajax/load.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/ajax/parseJSON.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/ajax/parseXML.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/ajax/script.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/ajax/var/nonce.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/ajax/var/rquery.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/ajax/xhr.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/attributes.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/attributes/attr.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/attributes/classes.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/attributes/prop.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/attributes/support.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/attributes/val.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/callbacks.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/core.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/core/access.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/core/init.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/core/parseHTML.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/core/ready.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/core/var/rsingleTag.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/css.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/css/addGetHookIf.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/css/curCSS.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/css/defaultDisplay.js > PRE-CREATION > > 3rdparty/javascript/bower_components/jquery/src/css/hiddenVisibleSelectors.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/css/support.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/css/swap.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/css/var/cssExpand.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/css/var/getStyles.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/css/var/isHidden.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/css/var/rmargin.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/css/var/rnumnonpx.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/data.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/data/Data.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/data/accepts.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/data/var/data_priv.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/data/var/data_user.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/deferred.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/deprecated.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/dimensions.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/effects.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/effects/Tween.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/effects/animatedSelector.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/event.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/event/alias.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/event/support.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/exports/amd.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/exports/global.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/intro.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/jquery.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/manipulation.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/manipulation/_evalUrl.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/manipulation/support.js > PRE-CREATION > > 3rdparty/javascript/bower_components/jquery/src/manipulation/var/rcheckableType.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/offset.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/outro.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/queue.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/queue/delay.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/selector-native.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/selector-sizzle.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/selector.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/serialize.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/traversing.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/traversing/findFilter.js > PRE-CREATION > > 3rdparty/javascript/bower_components/jquery/src/traversing/var/rneedsContext.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/arr.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/class2type.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/concat.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/hasOwn.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/indexOf.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/pnum.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/push.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/rnotwhite.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/slice.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/strundefined.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/support.js PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/var/toString.js > PRE-CREATION > 3rdparty/javascript/bower_components/jquery/src/wrap.js PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/.bower.json > 4dc3ebf4b6324a984f38dd4f86f29fc647722ea4 > 3rdparty/javascript/bower_components/smart-table/.gitignore PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/CHANGELOG.md PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/GruntFile.js PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/README.md PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/Smart-Table.debug.js > b79c60edc70a68de1610a03daa074e8da2e2d71b > 3rdparty/javascript/bower_components/smart-table/Smart-Table.min.js > 49611b2fc143e9675cfa136b308b1156839b2ec1 > 3rdparty/javascript/bower_components/smart-table/bower.json > 68709ef479501f83af1acbfe2fad7b942cf677d3 > 3rdparty/javascript/bower_components/smart-table/config/karma-e2e.conf.js > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/config/karma.conf.js > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/example-app/css/app.css > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/example-app/css/bootstrap.css > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/example-app/index.html > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/example-app/js/Smart-Table.debug.js > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/example-app/js/app.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/example-app/lib/angular/angular.min.js > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/logs/.gitignore > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/package.json PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/scripts/e2e-test.bat > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/scripts/e2e-test.sh > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/scripts/test.bat > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/scripts/test.sh > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/scripts/watchr.rb > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/scripts/web-server.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/js/Column.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/js/Directives.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/js/Filters.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/js/Table.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/js/Template.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/js/TemplateUrlList.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/js/Utilities.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/js/ui-bootstrap-custom-tpls-0.4.0-SNAPSHOT.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/lib/angular/angular-bootstrap-prettify.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/lib/angular/angular-bootstrap.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/lib/angular/angular-cookies.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/lib/angular/angular-loader.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/lib/angular/angular-mocks.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/lib/angular/angular-resource.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/lib/angular/angular-sanitize.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/lib/angular/angular-scenario.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/lib/angular/angular.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/partials/defaultCell.html > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/partials/defaultHeader.html > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/partials/editableCell.html > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/partials/globalSearchCell.html > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/partials/pagination.html > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/partials/selectAllCheckbox.html > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/partials/selectionCheckbox.html > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/smart-table-module/partials/smartTable.html > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/test/e2e/runner.html > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/test/e2e/scenarios.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/test/lib/angular/angular-mocks.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/test/lib/angular/angular-scenario.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/test/lib/angular/version.txt > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/test/unit/ColumnSpec.js > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/test/unit/TableSpec.js > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/test/unit/UtilitiesSpec.js > PRE-CREATION > > 3rdparty/javascript/bower_components/smart-table/test/unit/directivesSpec.js > PRE-CREATION > 3rdparty/javascript/bower_components/smart-table/test/unit/filtersSpec.js > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java > f7da8c669cb02c2330dc106a5bf628f308200a59 > src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html > 23f0cdcedbef9e52b369220e294297c1de6c4bcd > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css > c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60 > src/main/resources/org/apache/aurora/scheduler/http/ui/index.html > c805a171a7caf87b0357d6c6ce336b25f884895b > src/main/resources/org/apache/aurora/scheduler/http/ui/job.html > 8437d3008d310261ec0b02e62dd13c64ee5dcc4f > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js > 87cdfb243a672e768839d5f84fc934d077994039 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js > b186ae2322b45f16eddb762501b074a6dbeb6b11 > src/main/resources/org/apache/aurora/scheduler/http/ui/role.html > 8b829bbb480926a432f741e68bdb71fefb3eecd0 > src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html > 00e3a259dcbc017be4f11eb1d04eaed987c312a0 > > Diff: https://reviews.apache.org/r/21790/diff/ > > > Testing > ------- > > ./gradlew run and ./gradlew build. > > > File Attachments > ---------------- > > home page > > https://reviews.apache.org/media/uploaded/files/2014/05/22/658ae4fb-7701-4da6-abbc-9922d8a71db4__Screen_Shot_2014-05-22_at_12.05.34_PM.png > role page > > https://reviews.apache.org/media/uploaded/files/2014/05/22/049a639e-f35f-4844-a02d-4f77bb81f224__Screen_Shot_2014-05-22_at_12.06.32_PM.png > role env page > > https://reviews.apache.org/media/uploaded/files/2014/05/22/759d50e5-6ab2-41bf-91b4-5d8954f07723__Screen_Shot_2014-05-22_at_12.06.04_PM.png > job page > > https://reviews.apache.org/media/uploaded/files/2014/05/22/00c7cd6b-d8f6-40b0-a62a-81953641382c__Screen_Shot_2014-05-22_at_12.05.34_PM.png > > > Thanks, > > Suman Karumuri > >
