----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21825/#review43875 -----------------------------------------------------------
Seems like the config bar should be above the tabs, or only on the 'Active tasks' tab. Also, is it possible to include counts on the tab headings? I worry people will overlook problems if there's no call to action on completed, for example. - Bill Farner On May 23, 2014, 6:54 p.m., Suman Karumuri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21825/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 6:54 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-425 > https://issues.apache.org/jira/browse/AURORA-425 > > > Repository: aurora > > > Description > ------- > > Moved task tables into active and completed tabs on job page. > Installed angular-ui/bootstrap project since we need the tabset directive > from it. > Upgraded angular js to version 1.2.9 from 1.2.6. > > > Diffs > ----- > > 3rdparty/javascript/bower_components/angular-bootstrap/.bower.json > PRE-CREATION > 3rdparty/javascript/bower_components/angular-bootstrap/bower.json > PRE-CREATION > 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.js > PRE-CREATION > > 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap-tpls.min.js > PRE-CREATION > 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.js > PRE-CREATION > 3rdparty/javascript/bower_components/angular-bootstrap/ui-bootstrap.min.js > PRE-CREATION > 3rdparty/javascript/bower_components/angular/.bower.json > ee8284d59e3d13b2c9ea444caebf4b3d07323460 > 3rdparty/javascript/bower_components/angular/angular.js > d4d7abc0b72626c0c7028c8ac013f4218df71d07 > 3rdparty/javascript/bower_components/angular/angular.min.js > d3daf08b075b48d53860fd1c119ff736efa9f6c4 > 3rdparty/javascript/bower_components/angular/angular.min.js.gzip > 879a6b82f0f72cc79b06918150327fd025474adb > 3rdparty/javascript/bower_components/angular/angular.min.js.map > 68739de57996eac63fbf4da9fd45fc93d80c899c > 3rdparty/javascript/bower_components/angular/bower.json > 9079df91659e6965eeff30ae68e0c22211e2ab14 > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java > f7da8c669cb02c2330dc106a5bf628f308200a59 > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css > c9a95ad3b3dcd53a68f1a6cb0fd22507af119b60 > src/main/resources/org/apache/aurora/scheduler/http/ui/index.html > c805a171a7caf87b0357d6c6ce336b25f884895b > src/main/resources/org/apache/aurora/scheduler/http/ui/job.html > 8437d3008d310261ec0b02e62dd13c64ee5dcc4f > src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js > aca1e396ec3653cbc2277cbf54ad1250f286b9f9 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js > b186ae2322b45f16eddb762501b074a6dbeb6b11 > > Diff: https://reviews.apache.org/r/21825/diff/ > > > Testing > ------- > > ./gradlew run && ./gradlew build > > > File Attachments > ---------------- > > active tasks tab > > https://reviews.apache.org/media/uploaded/files/2014/05/23/7366fb1a-13dd-4684-82ff-ed1a61c1e4ae__Screen_Shot_2014-05-22_at_6.20.25_PM.png > completed tasks tab > > https://reviews.apache.org/media/uploaded/files/2014/05/23/b053b9eb-52ee-4e64-9fde-abb69d5bd541__Screen_Shot_2014-05-22_at_6.20.32_PM.png > all tasks tab > > https://reviews.apache.org/media/uploaded/files/2014/05/23/2efe7251-c59e-4e22-a6c7-f1ab4d00a383__Screen_Shot_2014-05-22_at_6.20.39_PM.png > > > Thanks, > > Suman Karumuri > >
