----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21830/#review43977 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/thrift/Util.java <https://reviews.apache.org/r/21830/#comment78221> s/too/to src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java <https://reviews.apache.org/r/21830/#comment78222> We don't inline @Inject with methods, why here? src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/21830/#comment78223> Would it make sense to change it to list instead? I can imagine how the order may be helpful here in troubleshooting multi-message errors. - Maxim Khutornenko On May 23, 2014, 7:30 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21830/ > ----------------------------------------------------------- > > (Updated May 23, 2014, 7:30 p.m.) > > > Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Maxim > Khutornenko. > > > Bugs: AURORA-461 > https://issues.apache.org/jira/browse/AURORA-461 > > > Repository: aurora > > > Description > ------- > > This also included a small amount of cleanup in the aop package, since we now > use a uniform response type. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 88bd20d55b488b30dba70d8c1469e058d1c761bc > src/main/java/org/apache/aurora/scheduler/thrift/Util.java PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/thrift/aop/FeatureToggleInterceptor.java > 2134609769d74755d11b43015bd1d17ad49132ec > src/main/java/org/apache/aurora/scheduler/thrift/aop/Interceptors.java > ee22af10a469db1a3cc46d9092285977b5526f9e > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java > 5f8143c146a25196d6ecc10d93c8e8e99d4e06be > > src/main/java/org/apache/aurora/scheduler/thrift/aop/UserCapabilityInterceptor.java > 801e7ae7c8fc5fa5d5e1f9934a34f8e809aa0798 > src/main/python/apache/aurora/client/api/__init__.py > f671ed860eee6ce57e4fee5e4ebbfb926fc2b3ae > src/main/python/apache/aurora/client/api/command_runner.py > c1459c4ba8553d82b9d9d1fdbf674f45006ca96c > src/main/python/apache/aurora/client/api/instance_watcher.py > 8992b93d25ce71b5784bad24429fd32356f64763 > src/main/python/apache/aurora/client/api/quota_check.py > cfb56d7ae7e0f138c541b3125f27f010c0fe6c2a > src/main/python/apache/aurora/client/api/restarter.py > bceba63efd6e3ed198d3bdd041c8c961aa9c98c6 > src/main/python/apache/aurora/client/api/updater.py > e8692ea4fdf924fb1ea06803d5e7321340754442 > src/main/python/apache/aurora/client/base.py > cc08c18b1c4e664ca38efccca7f6d96a070479ba > src/main/python/apache/aurora/client/cli/context.py > fae30f6fc829699b6d775bce3fff1be3cde3dd65 > src/main/python/apache/aurora/client/cli/jobs.py > c318926439dba2c99a4a34c153c8d3d0bef17207 > src/main/python/apache/aurora/client/cli/task.py > 1bd746da2f39f78b1497701f69777ca3ea6b70ea > src/main/python/apache/aurora/client/commands/admin.py > 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02 > src/main/python/apache/aurora/client/commands/core.py > 9b4c76a57eb7cb99a024febc5623606389fe7557 > src/main/python/apache/aurora/client/hooks/hooked_api.py > 0568d91b4b13d8e3891eef2ce908d632e0402fa8 > src/main/thrift/org/apache/aurora/gen/api.thrift > aad74fd6db573f1502c54fa31f7aa5ee53cf9ad4 > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > a9e5d89465a14c0d8bd4540b34e311763357f78f > src/test/python/apache/aurora/client/api/test_disambiguator.py > e9fe47ae248473cccb42730c458d199219b1ffe7 > src/test/python/apache/aurora/client/api/test_instance_watcher.py > 09dda3bed6a5097f6dff8153249a7460a5b24d58 > src/test/python/apache/aurora/client/api/test_job_monitor.py > 3df042019d845421e5c8d79232ed865e342d44fc > src/test/python/apache/aurora/client/api/test_quota_check.py > 854a98c9afe8e265a8794cbe6f9dc8af07181394 > src/test/python/apache/aurora/client/api/test_restarter.py > 807994502a7f265bf4aae9b4af7ba77a2c3a9ace > src/test/python/apache/aurora/client/api/test_sla.py > 02b36d5cd3322f6f03f1d6d525745faf2513f065 > src/test/python/apache/aurora/client/api/test_updater.py > 03a14186646daede689ac77e2ab7144aa5a7fa14 > src/test/python/apache/aurora/client/cli/util.py > ccb6ea51eb636c2c564a0ee1a0ba2d41707bd2ca > src/test/python/apache/aurora/client/commands/test_kill.py > bc3b92bdfc7838b6a0671078ef315ccd707eb5a5 > src/test/python/apache/aurora/client/commands/util.py > 4e587f320c785b56f5812364d50946cb2b6f03dc > > Diff: https://reviews.apache.org/r/21830/diff/ > > > Testing > ------- > > ./build-support/jenkins/build.sh > > > Thanks, > > Bill Farner > >
