-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review44015
-----------------------------------------------------------

Ship it!


thanks!


src/main/python/apache/aurora/client/api/sla.py
<https://reviews.apache.org/r/21741/#comment78261>

    In practice, we operate on only a single grouping, and it'd be kind of nice 
to specify this only once as opposed to each time we invoke this method.. 
though I'm not sure how to do that cleanly (especially when we call this method 
once via the command line)
    
    (so not a blocker to ship unless we can think of a clean way to improve 
this api)



src/test/python/apache/aurora/client/api/test_sla.py
<https://reviews.apache.org/r/21741/#comment78258>

    add a double newline? (unless this passes check style, in which case ignore 
me)


- Joe Smith


On May 22, 2014, 6:12 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21741/
> -----------------------------------------------------------
> 
> (Updated May 22, 2014, 6:12 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
> 
> 
> Bugs: AURORA-441
>     https://issues.apache.org/jira/browse/AURORA-441
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moved grouping functionality from maintenance into base and added grouping 
> support for the sla commands.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 
> 1890f80ca7981af020ab12957879795bd86b6327 
>   src/main/python/apache/aurora/client/api/sla.py 
> 0738db89969a0d2ac69637913031828cbf2e1c73 
>   src/main/python/apache/aurora/client/base.py 
> cc08c18b1c4e664ca38efccca7f6d96a070479ba 
>   src/main/python/apache/aurora/client/commands/admin.py 
> 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02 
>   src/main/python/apache/aurora/client/commands/maintenance.py 
> d020e4c36594d717537d5e8e10588e1e05e0d5db 
>   src/test/python/apache/aurora/admin/test_host_maintenance.py 
> 8c766385fc091f066a77cda2941aa11cc9a64d46 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 02b36d5cd3322f6f03f1d6d525745faf2513f065 
>   src/test/python/apache/aurora/client/commands/test_admin_sla.py 
> df007f2e0de70cd6c3295119d7ef3877cfce036d 
> 
> Diff: https://reviews.apache.org/r/21741/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to