----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/#review44318 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java <https://reviews.apache.org/r/22065/#comment78691> Iterable<Trigger> cronTriggers = Iterables.filter(scheduler.getTriggersOfJob(jobKey), Predicates.instanceOf(CronTrigger.class); for (Trigger trigger : cronTriggers) { ... } (reformat as you see fit, tried to make it look nice here) src/main/java/org/apache/aurora/scheduler/http/Cron.java <https://reviews.apache.org/r/22065/#comment78689> While you're in the neighborhood...how about some test coverage in here? Ideally the test would consume json. This requires some overhead to set up the environment, which i will be grateful to reuse as i push for more test coverage (this package is the worst in that regard). - Bill Farner On May 29, 2014, 10:33 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22065/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 10:33 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-478 > https://issues.apache.org/jira/browse/AURORA-478 > > > Repository: aurora > > > Description > ------- > > Fix /cron endpoint. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java > 3359425b5f19e68f33c46c5191ad100c1857d978 > src/main/java/org/apache/aurora/scheduler/http/Cron.java > 6ccf5833012b4282e6a0fc94db39ac4ccd5ce77f > > src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java > efa0a583dfa63ae1240a2fff128d97497c83536e > > Diff: https://reviews.apache.org/r/22065/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > ./gradlew run > curl -s http://localhost:8081/cron | python -m json.tool > > > Thanks, > > Kevin Sweeney > >
