-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22082/
-----------------------------------------------------------
Review request for Aurora, Antoine Tollenaere and David McLaughlin.
Bugs: aurora-496
https://issues.apache.org/jira/browse/aurora-496
Repository: aurora
Description
-------
Modify the way that config binding helpers get registered.
Config binding helpers (components that add macros to the pystachio
config language) self-registered in a way that made it difficult to
provide parameters to initialize them.
This change switches to an explicit construction/registration, instead
of auto-construction when the class is registered. (Interestingly, this
is the way that the documentation on the binding helpers code says that
it works!)
With this change, instead of writing:
FooHelper.register()
You write:
BindingHelper.register(FooHelper())
Which makes it possible to do:
BindingHelper.register(FooHelper(url=bar))
Diffs
-----
src/main/python/apache/aurora/client/binding_helper.py
47448e061c4afd85b88ee3f106f49884e2369e8a
Diff: https://reviews.apache.org/r/22082/diff/
Testing
-------
All client unit tests run and passed.
Thanks,
Mark Chu-Carroll
