-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22233/#review44723
-----------------------------------------------------------



src/main/python/apache/aurora/client/api/command_runner.py
<https://reviews.apache.org/r/22233/#comment79197>

    this should probably be logging.DEBUG
    
    if you really want to make it an instancemethod, it should go along with 
the other instancemethods below __init__.  
    
    alternatively, it can stay a static/classmethod by passing a logger in 
'args' (e.g. by tacking it onto the end of the list returned by 
self.process_arguments)


- Brian Wickman


On June 4, 2014, 2:56 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22233/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 2:56 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: aurora-503
>     https://issues.apache.org/jira/browse/aurora-503
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix logging in the command-runner.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/__init__.py 
> 1af0f8fa77e15444027c553404495d1ebeb5e540 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> 8b29f35f85f4173158e0d46aba091915bf7200d0 
>   src/main/python/apache/aurora/client/cli/client.py 
> 1fb5364894d230646592942434eb1da6554d5c05 
>   src/main/python/apache/aurora/client/cli/config.py 
> 034c68e52ac8d2fbabb9dbf4f397f1a4920d0122 
>   src/main/python/apache/aurora/client/cli/cron.py 
> c30a0a605412229f3e4cddbe8c5ae746f256e30c 
>   src/main/python/apache/aurora/client/cli/task.py 
> fe11f38b902ae54a4048ba114055ba30e8abe6c5 
>   src/test/python/apache/aurora/client/api/test_sla.py 
> 9c3bb6d386abbdbbfa8746639798ddca01d54fe9 
>   src/test/python/apache/aurora/client/cli/test_config_noun.py 
> 7a9d733835e204bfd179e698bc335435b837d24b 
>   src/test/python/apache/aurora/client/cli/test_cron.py 
> 049405a4323fc73102d6ac1dae2230be4325c530 
>   src/test/python/apache/aurora/client/cli/test_task_run.py 
> 26633981d561eeed498acece03c025bec00e11bd 
>   src/test/python/apache/aurora/client/test_config.py 
> 4b3e1499c7447792288f4b480cbd756c8e19a831 
>   src/test/sh/org/apache/aurora/e2e/http_example.py 
> 04f7fa5c9bf36a36b395d870db02b97f8e5b6c66 
> 
> Diff: https://reviews.apache.org/r/22233/diff/
> 
> 
> Testing
> -------
> 
> Added check to unit tests; all client tests pass.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to