-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22280/
-----------------------------------------------------------

(Updated June 9, 2014, 6:42 p.m.)


Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.


Changes
-------

Added transport test

mba=aurora=; PANTS_PY_COVERAGE=1 ./pants 
src/test/python/apache/aurora/common:test_transport -v
Build operating on targets: 
OrderedSet([PythonTests(src/test/python/apache/aurora/common/BUILD:test_transport)])
======================================= test session starts 
========================================
platform darwin -- Python 2.6.7 -- py-1.4.20 -- pytest-2.5.2 -- 
/System/Library/Frameworks/Python.framework/Versions/2.6/bin/python2.6
collected 3 items 

src/test/python/apache/aurora/common/test_transport.py:22: 
test_request_transport_integration PASSED
src/test/python/apache/aurora/common/test_transport.py:49: 
test_request_transport_timeout PASSED
src/test/python/apache/aurora/common/test_transport.py:74: 
test_request_any_other_exception PASSEDCoverage.py warning: Trace function 
changed, measurement is likely wrong: None

------------------------- coverage: platform darwin, python 2.6.7-final-0 
--------------------------
Name                                                                            
                    Stmts   Miss Branch BrMiss  Cover
-------------------------------------------------------------------------------------------------------------------------------------
/private/var/folders/4d/9tz0cd5n2n7947xs21gspsxc0000gp/T/tmpULUFvv/apache/aurora/common/__init__
        1      0      0      0   100%
/private/var/folders/4d/9tz0cd5n2n7947xs21gspsxc0000gp/T/tmpULUFvv/apache/aurora/common/transport
      50      4      2      1    90%
-------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                           
                       51      4      2      1    91%


Repository: aurora


Description
-------

Implement a TRequestsClient as a prelude to kerberization.

Sending out for early feedback.  This could probably be shipped as-is but 
curious to see how people feel about this approach.  This is the first bit of 
AURORA-515.  To add kerberos support, we just need to add a dependency on 
requests_kerberos and inject KerberosAuth() as the 'auth=' parameter to 
TRequestsClient with the proper service principal specified.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/api/BUILD 
6968d62e663a3d45b86d665ca4090be49e6426a6 
  src/main/python/apache/aurora/client/api/scheduler_client.py 
86ccdd982ddd678a8eb86f3d7be2761ced1d7b6c 
  src/main/python/apache/aurora/common/BUILD 
0de0cf76c0f19a6cee44cfb558096d2ff010a014 
  src/main/python/apache/aurora/common/transport.py PRE-CREATION 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py 
6b23a4a5e23f0724e418cefaadb2429480353272 
  src/test/python/apache/aurora/common/BUILD 
4fc778899dbae8ac2c1f802fb7c01903f6e8fc34 
  src/test/python/apache/aurora/common/test_transport.py PRE-CREATION 

Diff: https://reviews.apache.org/r/22280/diff/


Testing
-------

Updated client/api tests for the new transport.


Thanks,

Brian Wickman

Reply via email to