> On June 11, 2014, 6:40 p.m., Maxim Khutornenko wrote:
> > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java,
> >  line 1244
> > <https://reviews.apache.org/r/22448/diff/2/?file=607510#file607510line1244>
> >
> >     How about a test that validates all tasks were returned in multiple 
> > pages with no dupes? I.e.:
> >     1,2,3,4
> >     5,6,7,8
> >     9,10

Hmm, isn't that the responsibility of the client to pass the correct 
offset/limit each time? 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22448/#review45410
-----------------------------------------------------------


On June 11, 2014, 6:32 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22448/
> -----------------------------------------------------------
> 
> (Updated June 11, 2014, 6:32 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-521
>     https://issues.apache.org/jira/browse/AURORA-521
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add pagination to getTasksStatus
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  d9c3a1eecec4995b0539429b1079ff63118fb9e5 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> e72bcfb57d288d585307549be5d74067ab08c42b 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  299679618f135f29bbf4e6372585ae46a1224a27 
> 
> Diff: https://reviews.apache.org/r/22448/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Reply via email to