----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22429/#review45449 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/22429/#comment80313> s/public/private? src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/22429/#comment80320> Better use: IJobKey jobKey = JobKeys.assertValid(IJobKey.build(mutableJobKey)); src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/22429/#comment80314> This used only in one place. Consider inlining it. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/22429/#comment80315> Any reason to do a deep copy of it here? src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/22429/#comment80316> This could be merged with activeTasks to eliminate naming confusion. src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/22429/#comment80318> s/byInstance/taskByInstance? src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/22429/#comment80319> Merge it with okResponse(...)? src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java <https://reviews.apache.org/r/22429/#comment80317> How about a test returning empty result in case job key has no match? - Maxim Khutornenko On June 10, 2014, 6:44 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22429/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 6:44 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: AURORA-519 > https://issues.apache.org/jira/browse/AURORA-519 > > > Repository: aurora > > > Description > ------- > > Add getConfigGroupSummary API endpoint, which returns a TaskConfig -> > Set<InstanceId> struct for active tasks. This will let us paginate active > tasks, or drop TaskConfig from the getTasksStatus response in the future. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > d9c3a1eecec4995b0539429b1079ff63118fb9e5 > src/main/thrift/org/apache/aurora/gen/api.thrift > e72bcfb57d288d585307549be5d74067ab08c42b > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > 299679618f135f29bbf4e6372585ae46a1224a27 > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > cfe45d1137ca3dec56b0cc4f8612faeedbf44acf > > Diff: https://reviews.apache.org/r/22429/diff/ > > > Testing > ------- > > ./gradlew build > > > Thanks, > > David McLaughlin > >