-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22489/#review45531
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/async/Preemptor.java
<https://reviews.apache.org/r/22489/#comment80377>

    The filtering algorithm awareness of production flag and priority value is 
partially replicated here instead of having it in a single place as before. 
This is not a big problem now but may become when we keep adding business rules 
around preemption. Could you at least extract a method with this check and put 
it closer to canPreempt()?


- Maxim Khutornenko


On June 12, 2014, 1:21 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22489/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 1:21 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-524
>     https://issues.apache.org/jira/browse/AURORA-524
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Short-circuit preemptor on min-priority non-prod tasks.
> 
> Refactor the Preemptor to short-circuit when there's no hope a task could be 
> preempted. This will prevent hopeless preemption attempts from being included 
> in the count, making the ratio of (preemptor_no_slots_found / 
> preemptor_attempts) a meaningful indicator of cluster health. There may also 
> be a small performance improvement, but that's not the goal of this change.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 
> f29ad7fe1a0d388b6d9558df7b9b01accd433fe5 
>   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
> 1be16374aeebaee59063aec982690ffa1fbdcf0f 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java
>  47cb70bb092a20971e81c867218836d8bd9fbdef 
>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 
> 3578bb35aa642b0679ee017b79dbcf6591235d94 
> 
> Diff: https://reviews.apache.org/r/22489/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>

Reply via email to