-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22697/#review46442
-----------------------------------------------------------


Overall the content looks good and thorough.  Can you push a branch to github 
and link to it in the review description?  This way we can have a preview of 
the rendering.


docs/sla.md
<https://reviews.apache.org/r/22697/#comment81827>

    How about "Aurora SLA Measurement"?  Given that this works above a job, 
broadened scope seems like a good idea.



docs/sla.md
<https://reviews.apache.org/r/22697/#comment81829>

    Might want to eschew discussion of implementation details a bit.  How about 
"Counters that track SLA measurements are computed periodically within the 
scheduler."



docs/sla.md
<https://reviews.apache.org/r/22697/#comment81830>

    s/core //?



docs/sla.md
<https://reviews.apache.org/r/22697/#comment81831>

    Before this, a bit of prose about how we detect platform unavailability 
would be useful.  i.e. it's a red flag that the term LOST does not appear in 
the document.  It's good that you link to the source of truth 
(SlaAlgorithm.java), but a sentence or two about mesos and LOST status would 
fill in a big contextual blank.



docs/sla.md
<https://reviews.apache.org/r/22697/#comment81832>

    Nit: a user can indirectly cause service downtime when their application 
exits.



docs/sla.md
<https://reviews.apache.org/r/22697/#comment81828>

    You can actually link directly to the source path for simpler discovery.



docs/sla.md
<https://reviews.apache.org/r/22697/#comment81833>

    s/Average/Median/
    
    s/get host-assigned/be assigned to a host/
    s/A combined/This is a combined/



docs/sla.md
<https://reviews.apache.org/r/22697/#comment81834>

    Rewording:
    "job scheduling performance dependency"
    
    to
    
    "the dependency of scheduling performance"



docs/sla.md
<https://reviews.apache.org/r/22697/#comment81835>

    Please link to the source defining these sizes.



docs/sla.md
<https://reviews.apache.org/r/22697/#comment81836>

    s/The //



docs/sla.md
<https://reviews.apache.org/r/22697/#comment81837>

    s/Average/Median/


- Bill Farner


On June 17, 2014, 9:14 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22697/
> -----------------------------------------------------------
> 
> (Updated June 17, 2014, 9:14 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-528
>     https://issues.apache.org/jira/browse/AURORA-528
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Documenting SLA stats.
> 
> 
> Diffs
> -----
> 
>   docs/sla.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/22697/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to