----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23199/#review47070 -----------------------------------------------------------
src/main/python/apache/aurora/client/cli/context.py <https://reviews.apache.org/r/23199/#comment82672> Don't you want to except IOError here in case the file does not exist or cannot be read? - Maxim Khutornenko On July 1, 2014, 3:03 p.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23199/ > ----------------------------------------------------------- > > (Updated July 1, 2014, 3:03 p.m.) > > > Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. > > > Bugs: aurora-567 > https://issues.apache.org/jira/browse/aurora-567 > > > Repository: aurora > > > Description > ------- > > Have client commands that load config files print the contents of the loaded > config file to > log at level TRANSCRIPT (aka INFO+1). > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/context.py > facd52c14e330c35889cec0292bb380cecff9641 > src/test/python/apache/aurora/client/cli/test_logging.py > b3c3b8deaa8961251a1be8121659e742b00f6df2 > > Diff: https://reviews.apache.org/r/23199/diff/ > > > Testing > ------- > > Added unit test of new functionality, ran all tests. > > > Thanks, > > Mark Chu-Carroll > >
