> On June 27, 2014, 3:10 p.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, lines 
> > 17-20
> > <https://reviews.apache.org/r/23107/diff/1/?file=619305#file619305line17>
> >
> >     Add UNIQUE constraint just to be defensive from the schema standpoint?

Good call, done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23107/#review46863
-----------------------------------------------------------


On June 27, 2014, 5:42 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23107/
> -----------------------------------------------------------
> 
> (Updated June 27, 2014, 5:42 a.m.)
> 
> 
> Review request for Aurora and Kevin Sweeney.
> 
> 
> Bugs: AURORA-555
>     https://issues.apache.org/jira/browse/AURORA-555
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Database-backed implementation of SchedulerStore.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
> 48b4404590d393cda393b8cc7bc0619934a75223 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> e23506b7a3546c896f3095c80e3a20a97bee77d3 
>   src/main/java/org/apache/aurora/scheduler/storage/SchedulerStore.java 
> 057a2e6a5f1c935eb0633cf5d97e582cd05d0c31 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
> 0e7f52c83fb450f631751a635fd4d85fc61e3bab 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 1738b95cd67cf990bd8aad8c744a1febe2d87f15 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
> c683e398640c7ebf2047ef308a701cb4897c58dc 
>   src/main/java/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
> 505c94d6800c1453b1b1f696ef774f5943973f19 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 083e3ffa9add639666c2a3bcad478678886c643f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemSchedulerStore.java 
> a78b395b2b7621a8b1b24e3b6ad2a21ab1900d9a 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
> 65750b61b864f0e830513039a7c9d727ac9d493d 
>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
> 23555c2483d7fe716243847f8478898e98fb5ac4 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/FrameworkIdMapper.xml
>  PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 3298eb38644b6fa7096801a69f8b88d0331ce4a7 
>   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 
> 57095cea18936fb2ddf92bce587aea58e81996c8 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DbSchedulerStoreTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  22a40481b5b246989c2e17a72a0325649382dde1 
> 
> Diff: https://reviews.apache.org/r/23107/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to