> On July 1, 2014, 6:14 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java, line 89
> > <https://reviews.apache.org/r/23188/diff/1/?file=620711#file620711line89>
> >
> >     I much prefer the previous signature.  Why not push the Set->String 
> > translation to the call site?
> 
> Maxim Khutornenko wrote:
>     That would require making Veto public, which I did not quite like. 
> Besides, there is only one user of that API and no other use cases that would 
> require a Set<Veto>. I don't quite like String either but that seemed like a 
> reasonable tradeoff given the current semantic. I am ok reverting it if you 
> think Veto can be made public.
> 
> Bill Farner wrote:
>     Yeah, i don't see much harm in making Veto visible.

Done.


> On July 1, 2014, 6:14 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> >  line 486
> > <https://reviews.apache.org/r/23188/diff/1/?file=620712#file620712line486>
> >
> >     Doesn't it make more sense to inject this filter into the query?

Sure, done.


> On July 1, 2014, 6:14 p.m., Bill Farner wrote:
> > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java, 
> > line 133
> > <https://reviews.apache.org/r/23188/diff/1/?file=620714#file620714line133>
> >
> >     The Set->String change rears its head here - since you now need to 
> > match the ordering to satisfy equals().
> 
> Maxim Khutornenko wrote:
>

Reverted.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23188/#review47111
-----------------------------------------------------------


On July 1, 2014, 12:28 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23188/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 12:28 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-377
>     https://issues.apache.org/jira/browse/AURORA-377
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding getPendingReason RPC to expose scheduling vetos in the UI/client.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java 
> c86f598e2ac226e0a356515b389e76f7c5efb67e 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  5d21e5ebe80cda75957475afa9c2b94e202b73b2 
>   src/main/thrift/org/apache/aurora/gen/api.thrift 
> 8ee43fa1f0e2e699b0f1a321e673e49221b528ad 
>   src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 
> b60b004adbd6753ec6fef125fd70286be5071c56 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  2b9edd41631b48dd729ec1dafcf0cd20808e9c7c 
>   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
> a746c48dd21a401b84ddcc610d7c99b4f35f8135 
> 
> Diff: https://reviews.apache.org/r/23188/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq clean build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to