----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23653/#review48053 -----------------------------------------------------------
Ship it! Ship It! - Kevin Sweeney On July 17, 2014, 1:36 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23653/ > ----------------------------------------------------------- > > (Updated July 17, 2014, 1:36 p.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-582 > https://issues.apache.org/jira/browse/AURORA-582 > > > Repository: aurora > > > Description > ------- > > I found MemAttributeStore#saveHostAttributes somewhat contrived (leading to > the logic error), so i've restructured the method to make the behavior more > straightforward. > > This code is soon to be superseded by https://reviews.apache.org/r/23105/. I > will make sure to update that review to ensure it does not regress. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStore.java > 4bb807c04e47a091c83a575850ebfc3b244bfa73 > > src/test/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStoreTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23653/diff/ > > > Testing > ------- > > Reproduced the issue in vagrant, and subsequently in unit test. > > ./gradlew build -Pq > > > Thanks, > > Bill Farner > >