-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23105/
-----------------------------------------------------------

(Updated July 17, 2014, 9:37 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-557
    https://issues.apache.org/jira/browse/AURORA-557


Repository: aurora


Description
-------

There are a few different characteristics of this mapper compared to others so 
far:
- custom type handler (see AbstractTEnumTypeHandler and 
MaintenanceModeTypeHandler)
- outer join (to allow a HostAttributes with an empty Attributes set)
- batch insert via foreach
- collection, and nested collection result mapping

You may find this page helpful to explain the features used: 
http://mybatis.github.io/mybatis-3/sqlmap-xml.html#Result_Maps


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/storage/db/AttributeMapper.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
99d725b07fca9b0c48bccbb8f1e677354bcced56 
  src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
0d8ad6108b061f7b3c39e3ab5ff08841d0dd2733 
  src/main/java/org/apache/aurora/scheduler/storage/db/EnumValueMapper.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
77cd8abffca6bf20d753abe35ee212a7cf53668b 
  
src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/AbstractTEnumTypeHandler.java
 PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/MaintenanceModeTypeHandler.java
 PRE-CREATION 
  
src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
 PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemAttributeStore.java 
82fcdddcc519ef36b0285fd4d9431090e8f029bb 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
5cddd12086d105224b5a74297d832ebf2e2384a3 
  src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
65565f1bb14dd4c6425f67f27ea06566d57b65cf 
  src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/storage/db/EnumValueMapper.xml 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml 
31b98cb3107a88756694922de01fa0ba267f3e9d 
  src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
3298eb38644b6fa7096801a69f8b88d0331ce4a7 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/23105/diff/


Testing
-------

./gradlew run -Pq


Thanks,

Bill Farner

Reply via email to