-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23863/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-587
https://issues.apache.org/jira/browse/AURORA-587
Repository: aurora
Description
-------
This is an exemplar ServerSet Announcer implementation in
apache.aurora.executor.common. Open to suggestions about wiring up -- right
now it is enabled via command line flags, but we don't have prior art for
invoking the executor with command line flags (I think the scheduler just takes
-thermos_executor_path, which is fine if we promote the pattern of writing a
thin shell wrapper around the executor.pex.) We can alternately switch to
entry_points style a la AURORA-216 prior to submitting this, so that people
just need to pip install as a plugin, but would require a separate review.
Open to ideas.
Diffs
-----
src/main/python/apache/aurora/executor/bin/BUILD
6b3f620a1d1b004c6be9965f6dceb7c8913a8e4c
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py
198f2f6feb3782a98c3784297599ad218b54209e
src/main/python/apache/aurora/executor/common/BUILD
d0ff6fbf594663cd12ffb4b6d3f330e3a1ac123c
src/main/python/apache/aurora/executor/common/announcer.py PRE-CREATION
src/test/python/apache/aurora/executor/common/BUILD
8b54e910a671cde0265ade3155cb495c6314347b
src/test/python/apache/aurora/executor/common/test_announcer.py PRE-CREATION
Diff: https://reviews.apache.org/r/23863/diff/
Testing
-------
./pants src/test/python/apache/aurora/executor/common:announcer -v
Thanks,
Brian Wickman
