----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24018/#review48935 -----------------------------------------------------------
Ship it! Thanks for linking to the release notes. Some relevant changes i spotted: > It’s no longer necessary to pass -g (or --guess-fields) to rbt post in order > to automatically fill in the Summary and Description fields. This is now done > automatically for brand new review requests. I'll have to see when i try it out, but this might be a negative change: > Commit ID Fields > Review Board 2.0 has a new field for showing the ID of the commit that has been > posted. > Now, when posting against a Git or Mercurial repository, this field will reflect > the ID of the commit that was posted. That makes it sound like the SHA is included in the review somewhere. For our development, this will just be a meaningless value. > The git-hook-set-submitted hook is a pre-receive hook that will automatically close > review requests when commits that reference them are pushed. This sounds _awesome_! > The git-hook-check-approval hook can block pushing code if the commit is not > reviewed or doesn’t yet have approval. This works with the new “approval” feature > in Review Board 2.0 to allow companies to decide under what conditions a change is > allowed to go in. This sounds like a really nice feature until we have our own sever-side hook to do the same. - Bill Farner On July 28, 2014, 11:29 p.m., Kevin Sweeney wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24018/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 11:29 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Update to RBTools 0.6.2 > > Lots of improvements, including git workflow integration - see > https://www.reviewboard.org/docs/releasenotes/rbtools/0.6/ > > > Diffs > ----- > > build-support/tools/list-missing-shipits > bd5b2ffc8fc8394f71eff73e20970fe494dff680 > docs/contributing.md d337da2be9b182a0c872574c3587d414c566331b > rbt 7875e8931d7fb4cb499cb870108357d9eed9b0cf > > Diff: https://reviews.apache.org/r/24018/diff/ > > > Testing > ------- > > ./rbt post > ./build-support/tools/list-missing-shipits > > > Thanks, > > Kevin Sweeney > >
