-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24059/
-----------------------------------------------------------

(Updated July 29, 2014, 9:44 p.m.)


Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.


Bugs: AURORA-606
    https://issues.apache.org/jira/browse/AURORA-606


Repository: aurora


Description (updated)
-------

This is somewhat a copy-paste of the original HttpModule [1], as the first step 
in a general improvement in how we interact with jetty.  I've left a TODO for 
the next step (simplify addition of static assets).

The only expected functional change is the removal of /pprof/*, which i have 
not found to produce useful output in practice (at least, not as useful as 
other standard JVM tools).

I've also removed our dependencies on twitter's jar-packaged jquery and 
bootstrap, which we no longer appear to use anywhere.


[1] 
https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/application/modules/HttpModule.java


Diffs
-----

  build.gradle 5919a984ae8d5067f72e6efe50ad590405e779eb 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
30b1ba623daa69a1e184cb91a92e58720648caa2 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
f429eda3bc2c9ae80a67dca8da8574eb7f92976b 
  src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
729e0ab035b29dc570a2128266112db5312138ed 
  src/test/java/org/apache/aurora/scheduler/http/ServletModuleTest.java 
90a001b38ce35fe4da666febde328c1af30f9663 

Diff: https://reviews.apache.org/r/24059/diff/


Testing
-------

./gradlew clean build -Pq

bash examples/vagrant/test_tutorial.sh

Manually clicked around in a local scheduler.


Thanks,

Bill Farner

Reply via email to