----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49168 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java <https://reviews.apache.org/r/24116/#comment86011> Drop a "Not implemented" message in here and it will nicely propagate out through the API. src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86017> Please doc this, and fields within. Ditto elsewhere. src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86016> Here's the enum i've sketched out in my branch, how do you feel about these instead? enum Status { INIT, ROLLING_FORWARD, ROLLING_BACK, ROLL_FORWARD_PAUSED, ROLL_BACK_PAUSED, ROLLED_FORWARD, ROLLED_BACK, ABORTED, ERROR } src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86018> Why does an update need to know the starting state? Shouldn't this be gleaned from the Update immediately before it? src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86019> Shouldn't this be a TaskConfig? src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86020> startTimestampMs? src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86021> endTimestampMs? src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86028> This should contain update events, and explicitly not the Update. Can you define a half-baked UpdateEvent struct? Just an instance ID and timestamp should be fine for now, along with a TODO. src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86012> Add a note about being not yet implemented here, for nice presentation in the auto-generated help pages. src/main/thrift/org/apache/aurora/gen/api.thrift <https://reviews.apache.org/r/24116/#comment86023> How would you feel about generalizing this to support more use cases, like getting all in-progress updates? You could accept more parameters for this: Response getUpdates(1: string role, 2: JobKey job, 3: UpdateStatus status) - Bill Farner On July 30, 2014, 9:12 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24116/ > ----------------------------------------------------------- > > (Updated July 30, 2014, 9:12 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-611 > https://issues.apache.org/jira/browse/AURORA-611 > > > Repository: aurora > > > Description > ------- > > First stab at update APIs. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 12de5a3e9e3aae217b30c385e2d7ec7b43863ae2 > src/main/thrift/org/apache/aurora/gen/api.thrift > 54b8985971719247a5d42d8676075a51045bbb92 > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > 2ea4a9ba0a1ea81fea5c4f5203457aa79ae67c10 > > Diff: https://reviews.apache.org/r/24116/diff/ > > > Testing > ------- > > gradle build > > > Thanks, > > Maxim Khutornenko > >
