> On July 31, 2014, 8:06 p.m., Joe Smith wrote:
> > src/test/python/apache/aurora/admin/test_admin_util.py, line 17
> > <https://reviews.apache.org/r/24019/diff/2/?file=644077#file644077line17>
> >
> >     did we change our import order?
> >     
> >     wasn't it
> >     
> >     stdlib
> >     current-projects-namespace
> >     3rdparty
> >     ?

That's what isort-run does. So, I guess yes :)


> On July 31, 2014, 8:06 p.m., Joe Smith wrote:
> > src/test/python/apache/aurora/admin/test_admin_util.py, line 36
> > <https://reviews.apache.org/r/24019/diff/2/?file=644077#file644077line36>
> >
> >     self.assertRaises[1]
> >     
> >     [1] 
> > https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertRaises

Good to know. Done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24019/#review49283
-----------------------------------------------------------


On July 29, 2014, 1:04 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24019/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 1:04 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-609
>     https://issues.apache.org/jira/browse/AURORA-609
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Blocking on post drain script call.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/admin_util.py 
> 04eecb7246f02191cd9308c747151e58b203b885 
>   src/test/python/apache/aurora/admin/BUILD 
> 20f744b4133ec665e476c00ff46d6b3f8e3add71 
>   src/test/python/apache/aurora/admin/test_admin_util.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24019/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to