-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24169/#review49310
-----------------------------------------------------------

Ship it!


Ship It!

- David McLaughlin


On July 31, 2014, 11:39 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24169/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 11:39 p.m.)
> 
> 
> Review request for Aurora and David McLaughlin.
> 
> 
> Bugs: AURORA-628
>     https://issues.apache.org/jira/browse/AURORA-628
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The typo is actually in the smart-table library :-/
> 
> http://lorenzofox3.github.io/smart-table-website/
> 
> > The template will be compiled so that if it contains directives they will be
> > considered as angular directives. Moreover, these directives can have access
> > to all the row and column data through the scope
> 
> > scope.column;//the column object
> > scope.dataRow;//the data row object
> > scope.formatedValue;//the formated value (not the raw string)
> 
> 
> Diffs
> -----
> 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 
> 6cc31aa800f923afdfd085a9292e4b24546ab124 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html 
> aa1af4ab579b2eae4f6c0113bd27cea48300f11a 
>   
> src/main/resources/org/apache/aurora/scheduler/http/ui/schedulingDetail.html 
> 94ec1a50b8e834e3a39eea20552dc1bbb3cb3d26 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html 
> 6b524675d8a2bea21e6efb9cb578064ed0844f38 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html 
> 77efb2a3d8fbfa8a620b20713480be861bd3fa65 
> 
> Diff: https://reviews.apache.org/r/24169/diff/
> 
> 
> Testing
> -------
> 
> Ran locally, links are no longer busted.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to