> On Aug. 4, 2014, 11:34 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java, > > line 44 > > <https://reviews.apache.org/r/24281/diff/1/?file=651305#file651305line44> > > > > Does this compile?
Everything build and checks out. What's your concern? - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24281/#review49530 ----------------------------------------------------------- On Aug. 4, 2014, 11:30 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24281/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2014, 11:30 p.m.) > > > Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-612 > https://issues.apache.org/jira/browse/AURORA-612 > > > Repository: aurora > > > Description > ------- > > Initial implementation of the saveUpdate() store API. > > Slightly repackaged thrift objects to reuse in update store. Also, changed > getUpdates to getUpdatesStatus to better reflect its meaning and make > consistent with getTasksStatus API. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java > be8943d90bb5d138635764730dacdf4e681096e4 > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > baa5ab6fb6a4efae875f224c66b17dd31ddfa4a9 > src/main/java/org/apache/aurora/scheduler/storage/UpdateStore.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/DBUpdateStore.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > 4dbfd8af98a65a05395c096f535ce461828705c4 > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java > 0493c5f23c26cc958233a5a917db1e83142abc0e > src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java > f32787356befa77a17387c17754d1e2a4c183c82 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > 67191e79063cd925203ed2d0ad87aae11a0fa5ad > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > 414492ff83960cb050d2842db979458d87b71c9a > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java > 0590ea1ab85a0708be017bbfe62ec8fe20f5a73a > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 24bd03f2007566b45f0e18296394fce35d63c1a1 > src/main/thrift/org/apache/aurora/gen/api.thrift > 595c8dfc3d28c2bfa92ae2226a28a8519d75b8c4 > src/main/thrift/org/apache/aurora/gen/storage.thrift > 927b6db60687d28e55c251040aa6c7acc322161d > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 9ec00bb28e3440c575d16aef4bd25acabcf33936 > > src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > defafb605ab00ad811f319dae0af5bd53407b8cc > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > 5c51175b5dd46330cfc743d234346ab3e592ec31 > src/test/resources/org/apache/aurora/gen/storage.thrift.md5 > 61f426b2219be068d57afb003a3cff75f72b8a2e > > Diff: https://reviews.apache.org/r/24281/diff/ > > > Testing > ------- > > gradle -Pq build > ./pants src/test/python:all > > > Thanks, > > Maxim Khutornenko > >
