----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24334/#review49651 -----------------------------------------------------------
Ship it! src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java <https://reviews.apache.org/r/24334/#comment86896> Bogus return values worry me, since it's conceivable for this to actually wind up written to the replicated log. It seems wise for the API to return Optional<IJobUpdateDetails> anyhow, so you could return Optional.absent() here. - Bill Farner On Aug. 5, 2014, 7:41 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24334/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 7:41 p.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-612 > https://issues.apache.org/jira/browse/AURORA-612 > > > Repository: aurora > > > Description > ------- > > Initial implementation of the UpdateStore (fetch and snapshot). > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java > 14f7e99e8479a4edf20c4cb88044faa4d7f13cc5 > src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java > 3c8080ee6f73103a827bb6af7f2f82b58e7b5215 > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > 3268416c3c71211317222be1fe6361bf84d2f1e9 > src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java > 49bdd2acfc1a39366063a09e62c12737295ff093 > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java > 43e528ff663dfedd247a083440cea0e09cf96376 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > 5435f4074ef4f11dee1ce38615e46d4c8d8bdb64 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > 91bd70620c67ac8620c0f15cdc73dca0d9cd0675 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > 1da0fe9adca197bea9272a714dc96e6eb913237b > src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java > f9a1e2ad2d90b160278a40302e7454ef0c0949a2 > src/main/thrift/org/apache/aurora/gen/api.thrift > d9aee9d53ade56fc450452a919fa0270b5d21968 > src/main/thrift/org/apache/aurora/gen/storage.thrift > a1d6384161d426778896874bb82586e8e2100485 > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > 5abb3e089d5a71ec7acffbf78d22b6e7fb5e9dcd > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 4ebfcaa356da741e482c83b68f59b177848454fc > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java > 15640474a06a1acb0bc4e7a21d8e7b657bc6c3e8 > > src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > fda1978c909ce0b3fed295cc372e926221044c5b > src/test/resources/org/apache/aurora/gen/api.thrift.md5 > 63444e6333c29903378fcafe2f8ba81c9f2e8e5a > src/test/resources/org/apache/aurora/gen/storage.thrift.md5 > a93291e9d422a93114a94f0edd25a22e9b16ebfb > > Diff: https://reviews.apache.org/r/24334/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > >
