----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24359/ -----------------------------------------------------------
(Updated Aug. 6, 2014, 1:14 a.m.) Review request for Aurora and Bill Farner. Changes ------- Fix the fix. Bugs: AURORA-638 https://issues.apache.org/jira/browse/AURORA-638 Repository: aurora Description ------- Fix tests. Diffs (updated) ----- src/test/python/apache/aurora/client/api/test_scheduler_client.py 8f5fe56ddeee1ba66ecb2ea976b0488161e481dc src/test/python/apache/aurora/executor/common/test_announcer.py e5c4ce4cd0edf0666c5546b734b39121ce93a45c Diff: https://reviews.apache.org/r/24359/diff/ Testing ------- Currently running ./pants src/test/python:all -v The announcer test does not fail on my laptop. But I predict what was happening is that since I was just doing 2 clock.tick(1.0)s with the ThreadedClock and the other end was doing a clock.sleep(2.0), there were no guarantees that code was getting executed unless I did a subsequent clock.tick(epsilon). I've instead just done clock.tick(> 2) to guarantee that code executes. Thanks, Brian Wickman