-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24357/#review49755
-----------------------------------------------------------


Heads up - i'll be sending a new diff shortly that collapses the two enums.  
This shouldn't change things too dramatically, but will result in less code.

- Bill Farner


On Aug. 6, 2014, 12:58 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24357/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2014, 12:58 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> When implementing the layer above InstanceUpdater, i found that the design 
> required a circular parent/child dependency, among other awkwardness.  The 
> redesign should be much easier to work with, and IMO is easier to test.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 
> 28635177ecd77626c5cb87b02dec225c26eea104 
>   src/main/java/org/apache/aurora/scheduler/updater/TaskController.java 
> b725a311647c1fa7d4344b359759d9f20e023533 
>   src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java 
> a84536369be2ec7620bfa586fa85580773022d30 
>   src/test/java/org/apache/aurora/scheduler/updater/TaskUtil.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24357/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to