----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24432/#review49834 -----------------------------------------------------------
Ship it! src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml <https://reviews.apache.org/r/24432/#comment87223> How about INNER JOIN instead to be totally explicit? - Maxim Khutornenko On Aug. 7, 2014, 12:03 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24432/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 12:03 a.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-640 > https://issues.apache.org/jira/browse/AURORA-640 > > > Repository: aurora > > > Description > ------- > > Fix incorrect join type used in LockMapper.xml. > > > Diffs > ----- > > > src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml > deb25bddd826ba8d5fc3af6f7b853fba8d59e681 > src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml > 9e1f8e683697b1af1543be332c6da550e547971e > src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java > 283fc7ea1c4c5c102c34894a5b3bc4d828c002ec > > Diff: https://reviews.apache.org/r/24432/diff/ > > > Testing > ------- > > Modified a test case to point out the issue. > > > Thanks, > > Bill Farner > >
