-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24431/#review49863
-----------------------------------------------------------
I missed this in a previous round, but i noticed that JobUpdate and
JobUpdateSummary both have an "updateId" field. Should the one in JobUpdate go
away?
struct JobUpdate {
1: string updateId
2: JobUpdateSummary summary
...
}
struct JobUpdateSummary {
1: string updateId
...
}
- Bill Farner
On Aug. 7, 2014, 12:01 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24431/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 12:01 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-612
> https://issues.apache.org/jira/browse/AURORA-612
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding SQL support for saving updates and fetching update details.
>
> The configuration and updateOnlyTheseInstances option support will come
> separately.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java
> 869590ed3c43c64936af42e60d82f5a6938475d3
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java
> 5d6521813e40eed5cf7e6e0285a7400624c4c5b2
> src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java
> 8a573f7b04ecc37a19e3886f334f626af577839a
>
> src/main/java/org/apache/aurora/scheduler/storage/db/JobInstanceUpdateEventMapper.java
> PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/JobKeyMapper.java
> 844714c08cdaf280c8862e933a95ab009bd9e464
>
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
> PRE-CREATION
>
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateEventMapper.java
> PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateMapper.java
> PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java
> 618d5b72fd3078ef59571b5f2e33ecce3eb7386c
>
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateActionTypeHandler.java
> PRE-CREATION
>
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateStatusTypeHandler.java
> PRE-CREATION
>
> src/main/java/org/apache/aurora/scheduler/storage/db/typehandlers/TypeHandlers.java
> f014123348e2b229b2bb9be0dce424327ec0dfbe
>
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobInstanceUpdateEventMapper.xml
> PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml
> 3997f9833a7289a49e4f4972efc3f953674bd41b
>
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
> PRE-CREATION
>
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateEventMapper.xml
> PRE-CREATION
>
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateMapper.xml
> PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql
> eb2216ae22ae95370d0b5cd15dbb3d61fca79272
>
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24431/diff/
>
>
> Testing
> -------
>
> gradle -Pq build
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
