----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24702/#review50598 -----------------------------------------------------------
LGTM, would like to reconcile the populateJobConfig situation before proceeding. src/main/python/apache/aurora/client/api/__init__.py <https://reviews.apache.org/r/24702/#comment88467> previously-acquired src/main/python/apache/aurora/client/api/__init__.py <https://reviews.apache.org/r/24702/#comment88468> Seems like the scheduler should automatically do this within startJobUpdate. Is there anything preventing that behavior? - Bill Farner On Aug. 14, 2014, 4:08 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24702/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 4:08 p.m.) > > > Review request for Aurora, Mark Chu-Carroll and Bill Farner. > > > Bugs: AURORA-615 > https://issues.apache.org/jira/browse/AURORA-615 > > > Repository: aurora > > > Description > ------- > > Implementing client job lock and start update APIs. > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/__init__.py > 371137e469fd65935f4048eaafdcf9b702e8c947 > src/main/python/apache/aurora/client/api/updater_util.py > cbb93e4d64a334dba9d091b68cf6d3594930fa31 > src/test/python/apache/aurora/client/api/BUILD > db5c22375378566f58ade5d6a0b7fcce75ad8394 > src/test/python/apache/aurora/client/api/test_api.py PRE-CREATION > > Diff: https://reviews.apache.org/r/24702/diff/ > > > Testing > ------- > > ./pants src/test/python/apache/aurora/client/api:api > > > Thanks, > > Maxim Khutornenko > >
