> On Aug. 14, 2014, 8:40 p.m., David McLaughlin wrote:
> > src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java, lines 
> > 112-121
> > <https://reviews.apache.org/r/24655/diff/2/?file=660725#file660725line112>
> >
> >     Do we need to do validation/sanity checking here of things like 
> > instance count versus the range(s) provided in updateOnlyTheseInstances?

Yes, there is a TODO in the SchedulerThriftInterface tracking this suggested by 
Bill.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24655/#review50632
-----------------------------------------------------------


On Aug. 14, 2014, 8:07 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24655/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 8:07 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-649
>     https://issues.apache.org/jira/browse/AURORA-649
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implementing startJobUpdate thrift API.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/state/StateModule.java 
> 2c712eff097c3334bfcf2559a52214367748d08a 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  9e9f3979ea36bfbb8f60be77a4b209cdd2e4892c 
>   src/test/java/org/apache/aurora/scheduler/state/JobUpdaterImplTest.java 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d34bd6f5fedddb8d70996dc0806b4158f4136874 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 2562ff944b7cb304ce5a60d3f74beee22f6cc7bc 
> 
> Diff: https://reviews.apache.org/r/24655/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to