> On Aug. 15, 2014, 1:54 a.m., Maxim Khutornenko wrote:
> > src/main/thrift/org/apache/aurora/gen/storage.thrift, line 77
> > <https://reviews.apache.org/r/24727/diff/1/?file=661129#file661129line77>
> >
> >     The SaveJobUpdate could also benefit from this comment.

Done.


> On Aug. 15, 2014, 1:54 a.m., Maxim Khutornenko wrote:
> > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml,
> >  line 329
> > <https://reviews.apache.org/r/24727/diff/1/?file=661127#file661127line329>
> >
> >     This data is only needed when saving snapshots 
> > (fetchAllJobUpdateDetails). Should we rather move this join into 
> > selectAllDetails and keep selectDetails as is for the perf reasons? 
> >     
> >     It would require splitting this sql block into a few refs though, so up 
> > to you.

I'll take the reduced complexity over the performance for now.  If this join 
poses a performance problem, we've got bigger issues here :-)


> On Aug. 15, 2014, 1:54 a.m., Maxim Khutornenko wrote:
> > src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java,
> >  line 372
> > <https://reviews.apache.org/r/24727/diff/1/?file=661132#file661132line372>
> >
> >     Should be easier to read with '\n' after every test case here.

Good call, done.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24727/#review50691
-----------------------------------------------------------


On Aug. 15, 2014, 1:11 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24727/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2014, 1:11 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Store a lock association with job updates.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 
> 3f083d60a882c6665d9891172edb9a5aeddade9b 
>   src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 
> c05833f30eaf79527599a7223791a6f4f5309388 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 
> d659aa124bd702589952da1b19854a00862b0c86 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java
>  d590219e9ff873bc7b9b740759b024c463c523cf 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
> 342bab0426ebeeab0b3d2d038d98dba1de836231 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 3d291dd21892c20a8eb9388744c8b2f10a811554 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 
> 2915ff00f3a2e3602414cedebbb0270e07dc869a 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
>  17c58b1a07f2fcef7fe8502540b347542b603e60 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
> 1cf803fe019290c042e5a73824e39a12072b2431 
>   src/main/thrift/org/apache/aurora/gen/storage.thrift 
> 9f8378ea3f5d386c3177207296bf4b436b730b45 
>   src/main/thrift/org/apache/aurora/gen/storage_local.thrift 
> becfd7528610a32af907489d021319d9b371c332 
>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 
> 2f2c3e12657e9af1edf819ff95d0da5db0c5de4b 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java
>  f695b85514bcc5cedb16e962124af3db052cb17a 
>   src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 
> ae4cef42d67556a22ea45eaa6d7542915924ffd1 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
> ebcb9103d75909080f5b6a69db3a1bf46cfd9780 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
>  bee9c9c1fb43c5703c291edc51cb1bb73aefc8e5 
> 
> Diff: https://reviews.apache.org/r/24727/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to