-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24835/#review50992
-----------------------------------------------------------

Ship it!


LGTM mod separation of concerns on JobUpdateStore.Mutable.


src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
<https://reviews.apache.org/r/24835/#comment88875>

    Just to draw a line in the sand w.r.t. responsibility, i'd prefer if only 
the update controller used JobUpdateStore.Mutable.  You could push this down by 
changing the signature to JobUpdateController.start() to accept the lock token.


- Bill Farner


On Aug. 19, 2014, 1:56 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24835/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2014, 1:56 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-649
>     https://issues.apache.org/jira/browse/AURORA-649
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implementing pause/resume/abort APIs.
> 
> Also, dropping JobUpdater in favor of JobUpdateController to avoid a 
> "SchedulerCore fate" (thin proxy interfaces with little to no extra logic).
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> 61ba4b2c292bb1a76f6133c7212b3cacded6f693 
>   src/main/java/org/apache/aurora/scheduler/state/JobUpdater.java 
> eb472e422bdc2e324a4aa48e911c7b13c4639674 
>   src/main/java/org/apache/aurora/scheduler/state/JobUpdaterImpl.java 
> 2c6460028f9999c17c6fb04b8b92d91ed53ff333 
>   src/main/java/org/apache/aurora/scheduler/state/StateModule.java 
> cc1eee4e19c092c0d401558ac01b54627f2d1290 
>   src/main/java/org/apache/aurora/scheduler/state/UUIDGenerator.java 
> 3938c302a68d3ccdda0dc33418a5db00a717bffd 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  0d8d75bfd4db15d5b00302fa37f90a9e85cce95e 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> 066238cfe51557123d1e055e47bd52aeed9d5579 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  3bbd6dda3e6823e1851efa3d45ea7fa5000d0f39 
>   src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 
> PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/state/JobUpdaterImplTest.java 
> 90b4e8af94c801792658646a01e5756810b9f787 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  04abeeb78b63d65b6b09cf1ebe277324a18a13b0 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 
> 43265fdab1ae900fb828374f6c69e562def2d682 
> 
> Diff: https://reviews.apache.org/r/24835/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to