-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24752/#review50997
-----------------------------------------------------------



src/main/python/apache/thermos/config/schema_helpers.py
<https://reviews.apache.org/r/24752/#comment88877>

    ``reduce`` is removed in python 3.x.  you could either do:
    
    ```python
    try:
      return max(map(cls.safe_get, waits))
    except ValueError:
      return 0
    ```
    
    or create the intermediate list:
    
    ```python
    waits = [cls.safe_get(wait) for wait in waits]
    return max(waits) if waits else 0
    ```
    
    both would be considered idiomatic.


- Brian Wickman


On Aug. 15, 2014, 11:26 p.m., Matthew Jeffryes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24752/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2014, 11:26 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Problem: combine_task and concat_task helpers lose the finalization_wait 
> information from all but the first task
> Resolution: use sum/max of finialization_wait values in 
> concat_task/combine_task
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/config/schema_helpers.py 
> 3feef02d110c154eb92533ccd597a6d517d074a2 
>   src/test/python/apache/thermos/config/test_schema.py 
> 85b04c0e4d9c29dd85b576b0c296f613879b31a7 
> 
> Diff: https://reviews.apache.org/r/24752/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all -vxs
> 
> 
> Thanks,
> 
> Matthew Jeffryes
> 
>

Reply via email to