> On Aug. 27, 2014, 10:32 p.m., Brian Wickman wrote:
> > Ship It!
> 
> Brian Wickman wrote:
>     For future reference, the protocol here now is the person providing final 
> required ship-it (me, since I'm the only reviewer) merges the change to 
> master if the review was published by a non-committer.  I'll merge this 
> promptly.

However, *I think* you are still responsible for managing the lifecycle of the 
AURORA-670 ticket.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25108/#review51709
-----------------------------------------------------------


On Aug. 27, 2014, 6:40 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25108/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 6:40 p.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Bugs: AURORA-670
>     https://issues.apache.org/jira/browse/AURORA-670
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix default logger in command runner.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/command_runner.py 
> 58c298419387ede18e589a80609bc49d497ba760 
> 
> Diff: https://reviews.apache.org/r/25108/diff/
> 
> 
> Testing
> -------
> 
> Before:
> 
>   $ ./pants py src/main/python/apache/aurora/client/bin:aurora_client run 
> devcluster/vagrant/test/http_example 'pwd'
>   /home/vagrant/aurora src/main/python/apache/aurora/client/bin:aurora_client
>   /home/vagrant/aurora run
>   WARNING: ssh is an aurora clientv1 command which will be deprecated soon
>   To run this command using clientv2, use 'aurora task run "pwd"'
>   INFO] Starting new HTTP connection (1): precise64
>   INFO] Starting new HTTP connection (1): precise64
>   ERROR] 10
> 
> After this change:
> 
>   $ ./pants py src/main/python/apache/aurora/client/bin:aurora_client run 
> devcluster/vagrant/test/http_example 'pwd'
>   /home/vagrant/aurora src/main/python/apache/aurora/client/bin:aurora_client
>   /home/vagrant/aurora run
>   WARNING: ssh is an aurora clientv1 command which will be deprecated soon
>   To run this command using clientv2, use 'aurora task run "pwd"'
>   INFO] Starting new HTTP connection (1): precise64
>   INFO] Starting new HTTP connection (1): precise64
>     
> After this change with -v:
> 
>   $ ./pants py src/main/python/apache/aurora/client/bin:aurora_client run -v 
> devcluster/vagrant/test/http_example 'pwd'
>   /home/vagrant/aurora src/main/python/apache/aurora/client/bin:aurora_client
>   /home/vagrant/aurora run
>   WARNING: ssh is an aurora clientv1 command which will be deprecated soon
>   To run this command using clientv2, use 'aurora task run "pwd"'
>   INFO] Starting new HTTP connection (1): precise64
>   DEBUG] "POST /api HTTP/1.1" 200 None
>   INFO] Starting new HTTP connection (1): precise64
>   DEBUG] "POST /api HTTP/1.1" 200 None
>   DEBUG] Running command: ['ssh', '-n', 'vagrant@192.168.33.7', u'cd 
> /var/lib/mesos/slaves/*/frameworks/*/executors/thermos-1409163061330-vagrant-test-http_example-1-d1b0b32d-f968-42fb-b99d-214600a71a23/runs/latest/sandbox;pwd']
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to