-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/
-----------------------------------------------------------

(Updated Sept. 2, 2014, 9:06 p.m.)


Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman.


Changes
-------

e2e looks ~good, need to follow up on a potential Kazoo error though:

vagrant ssh -c 'env SERVERSET=/aurora/vagrant/test/httpexample PEXINTERPRETER=1 
aurora /vagrant/src/test/sh/org/apache/aurora/e2e/validate_serverset.py'
Announced members: [u'member_0000000001', u'member_0000000002', 
u'member_0000000000', u'member_0000000003']
Announced members: [u'member_0000000002', u'member_0000000000', 
u'member_0000000003']
Announced members: [u'member_0000000002', u'member_0000000000', 
u'member_0000000003', u'member_0000000004']
Exception in thread Thread-3 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
File "/usr/lib/python2.7/threading.py", line 810, in bootstrap_inner
File "/usr/lib/python2.7/threading.py", line 763, in run
File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 465, in zk_loop
File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/retry.py",
 line 122, in call
File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 484, in _connect_loop
File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 534, in _connect_attempt
<type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'CLOSED'


Bugs: AURORA-674
    https://issues.apache.org/jira/browse/AURORA-674


Repository: aurora


Description
-------

There's an API change when moving the python executor to 0.20.0, which should 
deserve extra scrutiny. 


Diffs
-----

  3rdparty/python/BUILD edc446e6d76d53a4c10a703cf6e84e29b8d42366 
  Vagrantfile c8cb2d440330780c10eeff47d46cc1a3f1aa4910 
  build.gradle 66c8205c8354048c398623edf7ba75e721376b01 
  examples/vagrant/provision-dev-cluster.sh 
2ce74f8a6dc663b62d254bc9d3a5c06cb412107f 
  src/main/python/apache/aurora/executor/BUILD 
c1c50dbcdcaa56f8ff970ceac59d5db537e1d048 
  src/main/python/apache/aurora/executor/aurora_executor.py 
8985aeb60e2c890113ea7d25039cdab5b7c9a19e 
  src/main/python/apache/aurora/executor/bin/BUILD 
93517150db96600c92ea25c0de29ec20736d72f7 
  src/main/python/apache/aurora/executor/bin/gc_executor_main.py 
bc20dad1e5434a98fb51ab052efa8ced760e74e0 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
aacc19a3bd272b08dee8a77d7a64490d0fcad3fa 
  src/main/python/apache/aurora/executor/common/BUILD 
0a4d35afcbfca8730d8bb7373795f9b3b6a74fd7 
  src/main/python/apache/aurora/executor/common/health_checker.py 
671f4970d4637b8cb68ec89e5dfe96a2f4cd077b 
  src/main/python/apache/aurora/executor/common/kill_manager.py 
6e482cfa7d2e081804fe6992527bae0ac5b65080 
  src/main/python/apache/aurora/executor/common/status_checker.py 
eda30e38d34adc5c78b828d0aea31f0721bf9b20 
  src/main/python/apache/aurora/executor/executor_base.py 
c632b77d972f76f3e260bb7413aa6100cda46607 
  src/main/python/apache/aurora/executor/gc_executor.py 
c45d5eb9a99e310e0716abd626ca34615f63b0ae 
  src/main/python/apache/aurora/executor/thermos_task_runner.py 
03a40e63573322f2d40e59a8ce84e9b9a1b90aa6 
  src/test/python/apache/aurora/executor/BUILD 
3152ec0c0e7dfaec5d756542a89243756b27725d 
  src/test/python/apache/aurora/executor/common/BUILD 
6316c7fc724c8e2245f5ce1a93c4a2daecd9f26b 
  src/test/python/apache/aurora/executor/common/test_executor_timeout.py 
PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_health_checker.py 
baeaba29e7679203d83f6ea81455973baf07f324 
  src/test/python/apache/aurora/executor/common/test_kill_manager.py 
PRE-CREATION 
  src/test/python/apache/aurora/executor/common/test_status_checker.py 
6ca4fd469bdc7cd21033ccdea460292463bc1cf8 
  src/test/python/apache/aurora/executor/test_executor_base.py PRE-CREATION 
  src/test/python/apache/aurora/executor/test_gc_executor.py 
0b2278a94667ca4d43e8a84649ed5312acacf7bb 
  src/test/python/apache/aurora/executor/test_status_manager.py PRE-CREATION 
  src/test/python/apache/aurora/executor/test_thermos_executor.py 
55747a19478572e39d1f00f799727d3c3db174c9 
  src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
f7af70fda8fef91018ff9d10dc1db6d43fd16ac7 

Diff: https://reviews.apache.org/r/25208/diff/


Testing (updated)
-------

$ ./gradlew test

[tw-mbp13-jsmith aurora (yasumoto/mesos_0.20.0)]$ 
./build-support/python/checkstyle-check && ./pants 
./src/test/python/apache/aurora/executor:all
src.test.python.apache.aurora.executor.common.announcer                         
.....   SUCCESS
src.test.python.apache.aurora.executor.common.directory_sandbox                 
.....   SUCCESS
src.test.python.apache.aurora.executor.common.health_checker                    
.....   SUCCESS
src.test.python.apache.aurora.executor.common.status_checker                    
.....   SUCCESS
src.test.python.apache.aurora.executor.common.task_info                         
.....   SUCCESS
src.test.python.apache.aurora.executor.executor_base                            
.....   SUCCESS
src.test.python.apache.aurora.executor.executor_detector                        
.....   SUCCESS
src.test.python.apache.aurora.executor.executor_vars                            
.....   SUCCESS
src.test.python.apache.aurora.executor.gc_executor                              
.....   SUCCESS
src.test.python.apache.aurora.executor.status_manager                           
.....   SUCCESS
src.test.python.apache.aurora.executor.thermos_executor                         
.....   SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner                      
.....   SUCCESS

e2e (not complete until https://reviews.apache.org/r/25206/ ships)
==> devcluster: stop: Unknown instance: 
==> devcluster: aurora-scheduler start/running, process 15447
+ test_http_example devcluster vagrant test http_example 192.168.33.7 
/vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora 
/vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora
+ local _cluster=devcluster _role=vagrant _env=test _job=http_example 
_sched_ip=192.168.33.7
+ local 
_base_config=/vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora
 
_updated_config=/vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora
+ jobkey=devcluster/vagrant/test/http_example
+ echo '== Creating job'
== Creating job
+ vagrant ssh -c 'aurora create devcluster/vagrant/test/http_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora'
WARNING: create is an aurora clientv1 command which will be deprecated soon
To run this command using clientv2, use 'aurora job create 
devcluster/vagrant/test/http_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example.aurora'
 INFO] Creating job http_example
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Response from scheduler: OK (message: None)
 INFO] Job url: http://192.168.33.7:8081/scheduler/vagrant/test/http_example
Connection to 127.0.0.1 closed.
+ base_url=http://192.168.33.7:8081
++ _curl -s http://192.168.33.7:8081/vars
++ curl --silent --fail --retry 4 --retry-delay 10 -s 
http://192.168.33.7:8081/vars
++ grep jvm_uptime_secs
++ wc -l
+ uptime='       1'
+ test 1 -eq 1
+ echo '== Updating test job'
== Updating test job
+ vagrant ssh -c 'aurora update devcluster/vagrant/test/http_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora'
WARNING: update is an aurora clientv1 command which will be deprecated soon
To run this command using clientv2, use 'aurora job update 
devcluster/vagrant/test/http_example 
/vagrant/src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora 
--health-check-interval-seconds=3'
 INFO] Updating job: http_example
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Instances to update: [0, 1, 2, 3]
 INFO] Processing in parallel with 2 worker thread(s)
 INFO] Examining instance: 0
 INFO] Killing instance: 0
 INFO] Examining instance: 1
 INFO] Killing instance: 1
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Killed: 1
 INFO] Adding instance: 1
 INFO] Killed: 0
 INFO] Adding instance: 0
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Added: 0
 INFO] Watching instances: [0]
 INFO] Added: 1
 INFO] Watching instances: [1]
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Detected RUNNING instance 0
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Detected RUNNING instance 1
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Instance 0 has been up and healthy for at least 10 seconds
 INFO] Examining instance: 2
 INFO] Adding instance: 2
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Added: 2
 INFO] Watching instances: [2]
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Detected RUNNING instance 2
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Instance 1 has been up and healthy for at least 10 seconds
 INFO] Examining instance: 3
 INFO] Adding instance: 3
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Added: 3
 INFO] Watching instances: [3]
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Detected RUNNING instance 3
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Instance 2 has been up and healthy for at least 10 seconds
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Instance 3 has been up and healthy for at least 10 seconds
 INFO] Update successful
 INFO] Starting new HTTP connection (1): 192.168.33.7
 INFO] Response from scheduler: OK (message: None)
Connection to 127.0.0.1 closed.
+ echo '== Validating announce'
== Validating announce
+ validate_serverset /aurora/vagrant/test/http_example
+ local retcode=0
+ vagrant ssh -c 'env SERVERSET=/aurora/vagrant/test/http_example 
PEX_INTERPRETER=1 aurora 
/vagrant/src/test/sh/org/apache/aurora/e2e/validate_serverset.py'
Announced members: [u'member_0000000001', u'member_0000000002', 
u'member_0000000000', u'member_0000000003']
Announced members: [u'member_0000000002', u'member_0000000000', 
u'member_0000000003']
Announced members: [u'member_0000000002', u'member_0000000000', 
u'member_0000000003', u'member_0000000004']
Exception in thread Thread-3 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
  File "/usr/lib/python2.7/threading.py", line 763, in run
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 465, in zk_loop
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/retry.py",
 line 122, in __call__
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 484, in _connect_loop
  File 
"/home/vagrant/.pex/install/kazoo-1.3.1-py2-none-any.whl.08501d46b91fe837d206a7a4e416a61bcf205214/kazoo-1.3.1-py2-none-any.whl/kazoo/protocol/connection.py",
 line 534, in _connect_attempt
<type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'CLOSED'
Connection to 127.0.0.1 closed.
+ retcode=1
+ [[ 1 = 1 ]]
+ echo 'Validated announced job.'
Validated announced job.
+ return 0
++ vagrant ssh -c 'aurora run devcluster/vagrant/test/http_example '\''pwd'\'''
++ wc -l


Thanks,

Joe Smith

Reply via email to