-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25297/#review52183
-----------------------------------------------------------



src/test/python/apache/aurora/client/cli/test_restart.py
<https://reviews.apache.org/r/25297/#comment90939>

    You've got comments on these asserts in the test above, but they're not 
replicated here. If that test were to change the reason for these numbers would 
be lost to the ages (or at least git history).
    
    How do you feel about pulling these asserts out to a separate function 
that's reused by both and documenting the reasoning there?



src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
<https://reviews.apache.org/r/25297/#comment90940>

    Kill trailing whitespace?


- Joshua Cohen


On Sept. 3, 2014, 2:07 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25297/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 2:07 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Maxim Khutornenko.
> 
> 
> Bugs: aurora-673
>     https://issues.apache.org/jira/browse/aurora-673
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Make config-file an optional parameter for "job restart."
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 
> ebc22aaa5a8aed311897b3ce9632b6f7175b6080 
>   src/test/python/apache/aurora/client/cli/test_restart.py 
> a1e7a5a94a2d336239df98e2600658b97c546901 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 
> 14a0b62c1b06179211d79f35a9c6df162c9a5999 
> 
> Diff: https://reviews.apache.org/r/25297/diff/
> 
> 
> Testing
> -------
> 
> - Ran all unit tests successfully.
> - Ran end-to-end tests successfully.
> - 
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>

Reply via email to